Reject .so files if -static is given.

[ruiu]

Summary

Previously, if you pass -static to lld, lld searches for only foo.a
and skips foo.so for -lfoo option. However, it didn't reject .so files
if you directly pass their pathnames via the command line, which is a bug.

[MaskRay]

LG, but not sure if the comment should mention -static. I think bfd's comment is better

https://sourceware.org/git/?p=binutils-gdb.git;a=blob;hb=2d5d5a8f0a8b5a03454bf168b7fa7024bb1ebbd8;f=ld/ldfile.c#l276

% ld.bfd t.o -static t.so
ld.bfd: attempted static link of dynamic object `t.so'

In gold, -static is a separate state, different from -Bdynamic/-Bstatic.

  if (!doing_static_link && options.is_static())
    {
      // We print out just the first .so we see; there may be others.
      gold_assert(input_objects->dynobj_begin() != input_objects->dynobj_end());
      gold_error(_("cannot mix -static with dynamic object %s"),
		 (*input_objects->dynobj_begin())->name().c_str());
    }

% gold t.o -static t.so
gold: error: cannot mix -static with dynamic object t.so

lld/test/ELF/static-error.s

7 ↗

(On Diff #178745)

POSIX sh does not support >& (but supports >&fd)

You may use 2>&1 >/dev/null | FileCheck if you want to emphasize stderr is checked.

[ruiu]

• Review comments.

[ruiu]

• Fix typo

[ruiu]

lld/test/ELF/static-error.s

7 ↗

(On Diff #178745)

Even thought lit tests support features such as redirection that you can find in Unix shells, these RUN commands are not run on a Unix shell, so it is safe to use >& as long as it works on lit.

[MaskRay]

lld/test/ELF/static-error.s

7 ↗

(On Diff #178745)

2>&1 | FileCheck LG.

[MaskRay]

lld/test/ELF/static-error.s

7 ↗

(On Diff #178745)

I don't know how lit runs the script.

On my machine, after running the test, I get a script:
llvm/$build/projects/lld/test/ELF/Output/aarch64-abs16.s.script

I can run that script with my $SHELL (zsh, but it may be sh for some people), so the POSIX shell compatibility is good.

ELF/Driver.cpp

if (!File->isEmpty() && !File->hasSymbolTable()) {
       return;
     }
 
     // Handle the regular case.
     Files.push_back(make<ArchiveFile>(std::move(File)));
     return;
   }
   case file_magic::elf_shared_object:
-    if (Config->Relocatable) {
+    if (Config->Static || Config->Relocatable) {
       error("attempted static link of dynamic object " + Path);
       return;
     }
 
     // DSOs usually have DT_SONAME tags in their ELF headers, and the
     // sonames are used to identify DSOs. But if they are missing,
     // they are identified by filenames. We don't know whether the new
     // file has a DT_SONAME or not because we haven't parsed it yet.

test/ELF/static-error.s

+// REQUIRES: x86
+// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %S/Inputs/shared.s -o %t.o
+// RUN: ld.lld -shared -o %t.so %t.o
+
+// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+// RUN: ld.lld -o /dev/null %t.o %t.so
+// RUN: not ld.lld -o /dev/null -static %t.o %t.so 2>&1 | FileCheck %s
+
+// CHECK: attempted static link of dynamic object
+
+.global _start
+_start:
+  nop

test/ELF/tls-static.s

 // REQUIRES: x86
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %S/Inputs/shared.s -o %tso
 // RUN: ld.lld -static %t -o %tout
 // RUN: ld.lld %t -o %tout
 // RUN: ld.lld -shared %tso -o %tshared
-// RUN: ld.lld -static %t %tshared -o %tout
 
 .global _start
 _start:
   data16
   leaq  foobar@TLSGD(%rip), %rdi
   data16
   data16
   rex64
   callq  __tls_get_addr@PLT
 
 
 .section        .tdata,"awT",@progbits
 .global  foobar
 foobar:
   .long   42