This is an archive of the discontinued LLVM Phabricator instance.

[asan] Restore ODR-violation detection on vtables
ClosedPublic

Authored by vitalybuka on Dec 17 2018, 5:30 PM.

Details

Summary

unnamed_addr is still useful for detecting of ODR violations on vtables

Still unnamed_addr with lld and --icf=safe or --icf=all can trigger false
reports which can be avoided with --icf=none or by using private aliases
with -fsanitize-address-use-odr-indicator

Diff Detail

Event Timeline

vitalybuka created this revision.Dec 17 2018, 5:30 PM

renamed classes

vitalybuka edited the summary of this revision. (Show Details)Dec 17 2018, 5:41 PM
vitalybuka edited the summary of this revision. (Show Details)

LGTM
Does it mean that either --icf=none or odr-indicators must be used to avoid false positives?

vitalybuka edited the summary of this revision. (Show Details)Dec 18 2018, 2:18 PM

Done

eugenis accepted this revision.Dec 18 2018, 2:25 PM
This revision is now accepted and ready to land.Dec 18 2018, 2:25 PM
This revision was automatically updated to reflect the committed changes.