[OpenMP] Fix LIBOMP_USE_DEBUGGER=ON build (PR38612)

[lebedev.ri]

Summary

Two things:

1. Those two variables had the wrong sigdness, which was resulting in "sign mismatch in comparison" warning.
2. The whole kmp_debugger.cpp wasn't being built, or rather, it was being built as-if USE_DEBUGGER was off, thus, nothing provided the definition of __kmp_omp_debug_struct_info, __kmp_debugging. Makes sense, because USE_DEBUGGER is set in kmp_config.h, which is not included explicitly. It is included by kmp.h, but that one is only included inside of the #if USE_DEBUGGER block.. I *think* this is the only source file with this issue, everything else seem to #include either kmp.h or kmp_config.h. The alternative solution would be to add add_compile_options(-include kmp_config.h) in CMake.

I did verify that __kmp_omp_debug_struct_info becomes available with this patch.

Fixes PR38612.

[lebedev.ri]

ping

[jlpeyton]

LGTM

[lebedev.ri]

In D55783#1352774, @jlpeyton wrote:

LGTM

Thank you for the review.

runtime/src/kmp.h

 }
 
 /* ------------------------------------------------------------------------- */
 
 extern kmp_global_t __kmp_global; /* global status */
 
 extern kmp_info_t __kmp_monitor;
 // For Debugging Support Library
-extern std::atomic<kmp_uint32> __kmp_team_counter;
+extern std::atomic<kmp_int32> __kmp_team_counter;
 // For Debugging Support Library
-extern std::atomic<kmp_uint32> __kmp_task_counter;
+extern std::atomic<kmp_int32> __kmp_task_counter;
 
 #if USE_DEBUGGER
 #define _KMP_GEN_ID(counter)                                                   \
   (__kmp_debugging ? KMP_ATOMIC_INC(&counter) + 1 : ~0)
 #else
 #define _KMP_GEN_ID(counter) (~0)
 #endif /* USE_DEBUGGER */
 

runtime/src/kmp_debugger.cpp

+#include "kmp_config.h"
+
 #if USE_DEBUGGER
 /*
  * kmp_debugger.cpp -- debugger support.
  */
 
 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure

runtime/src/kmp_global.cpp

 
 /* list of address of allocated caches for commons */
 kmp_cached_addr_t *__kmp_threadpriv_cache_list = NULL;
 
 int __kmp_init_counter = 0;
 int __kmp_root_counter = 0;
 int __kmp_version = 0;
 
-std::atomic<kmp_uint32> __kmp_team_counter = ATOMIC_VAR_INIT(0);
-std::atomic<kmp_uint32> __kmp_task_counter = ATOMIC_VAR_INIT(0);
+std::atomic<kmp_int32> __kmp_team_counter = ATOMIC_VAR_INIT(0);
+std::atomic<kmp_int32> __kmp_task_counter = ATOMIC_VAR_INIT(0);
 
 unsigned int __kmp_init_wait =
     KMP_DEFAULT_INIT_WAIT; /* initial number of spin-tests   */
 unsigned int __kmp_next_wait =
     KMP_DEFAULT_NEXT_WAIT; /* susequent number of spin-tests */
 
 size_t __kmp_stksize = KMP_DEFAULT_STKSIZE;
 #if KMP_USE_MONITOR