This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo] Move several private headers to include directory
ClosedPublic

Authored by yonghong-song on Dec 16 2018, 9:36 PM.

Details

Summary

This patch moved the following files in lib/CodeGen/AsmPrinter/

AsmPrinterHandler.h
DbgEntityHistoryCalculator.h
DebugHandlerBase.h

to include/llvm/CodeGen directory.

Such a change will enable Target to extend DebugHandlerBase
and emit Target specific debug info sections.

Signed-off-by: Yonghong Song <yhs@fb.com>

Diff Detail

Repository
rL LLVM

Event Timeline

yonghong-song created this revision.Dec 16 2018, 9:36 PM

@echristo @aprantl @dblaikie
This patch and two other patches (D55756, D55752) implemented a different mechanism
to generate BTF than patch D53736. D53736 has its most implementation under
lib/CodeGen/AsmPrinter. The new mechanism put most implementation under BTF target.

(1) https://reviews.llvm.org/D55755, moving header files
(2) https://reviews.llvm.org/D55756, changes some fields from private to protected
(3) https://reviews.llvm.org/D55752, changes only under target BPF

It will be good if you can help review all related patches and provide your opinions soon.
Thanks! Real appreciated.

echristo accepted this revision.Dec 18 2018, 2:35 PM

Thanks for the split! LGTM.

-eric

This revision is now accepted and ready to land.Dec 18 2018, 2:35 PM
This revision was automatically updated to reflect the committed changes.
llvm/trunk/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.h