This is an archive of the discontinued LLVM Phabricator instance.

[asan] Don't check ODR violations for particular types of globals
ClosedPublic

Authored by vitalybuka on Dec 12 2018, 2:29 PM.

Download Raw Diff

Details

Reviewers

eugenis
kcc

Commits

rGa257639a6935: [asan] Don't check ODR violations for particular types of globals
rCRT349015: [asan] Don't check ODR violations for particular types of globals
rL349015: [asan] Don't check ODR violations for particular types of globals
rC349015: [asan] Don't check ODR violations for particular types of globals

Summary

private and internal: should not trigger ODR at all.
unnamed_addr: current ODR checking approach fail and rereport false violation if
a linker merges such globals
linkonce_odr, weak_odr: could cause similar problems and they are already not
instrumented for ELF.

Diff Detail

Repository: rC Clang

Event Timeline

vitalybuka created this revision.Dec 12 2018, 2:29 PM

Herald added subscribers: hiraditya, kubamracek. · View Herald TranscriptDec 12 2018, 2:29 PM

Harbormaster completed remote builds in B25966: Diff 177928.Dec 12 2018, 2:29 PM

eugenis added inline comments.Dec 12 2018, 2:54 PM

llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
2193 ↗	(On Diff #177928)	did you mean "from linker optimizations"?

typo

Harbormaster completed remote builds in B25969: Diff 177947.Dec 12 2018, 3:02 PM

LGTM

This revision is now accepted and ready to land.Dec 12 2018, 3:08 PM

Closed by commit rC349015: [asan] Don't check ODR violations for particular types of globals (authored by vitalybuka). · Explain WhyDec 13 2018, 1:50 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: cfe-commits. · View Herald TranscriptDec 13 2018, 1:51 AM

Revision Contents

Path

Size

test/

CodeGen/

asan-static-odr.cpp

17 lines

Diff 178019

test/CodeGen/asan-static-odr.cpp

				// RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - -triple x86_64-linux %s \| FileCheck %s --check-prefixes=CHECK,ALIAS1

				// No alias on Windows but indicators should work.
				// RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - -triple x86_64-windows-msvc %s \| FileCheck %s --check-prefixes=CHECK,ALIAS0

				static int global;

				int main() {
				return global;
				}

				// CHECK-NOT: __odr_asan_gen
				// CHECK-NOT: private alias
				// CHECK: [[VAR:@.global.]] ={{.*}} global { i32, [60 x i8] } zeroinitializer, align 32
				// CHECK: @0 = internal global {{.}} [[VAR]] to i64), {{.}}, i64 -1 }]
				// CHECK: call void @__asan_register_globals(i64 ptrtoint ([1 x { i64, i64, i64, i64, i64, i64, i64, i64 }]* @0 to i64), i64 1)
				// CHECK: call void @__asan_unregister_globals(i64 ptrtoint ([1 x { i64, i64, i64, i64, i64, i64, i64, i64 }]* @0 to i64), i64 1)