Page MenuHomePhabricator

[hwasan] Verify Android TLS slot at startup.
ClosedPublic

Authored by eugenis on Dec 11 2018, 4:24 PM.

Details

Summary

Add a check that TLS_SLOT_TSAN / TLS_SLOT_SANITIZER, whichever
android_get_tls_slot is using, is not conflicting with
TLS_SLOT_DLERROR.

Diff Detail

Repository
rL LLVM

Event Timeline

eugenis created this revision.Dec 11 2018, 4:24 PM

Looks good to me.

compiler-rt/lib/hwasan/hwasan_linux.cc
295 ↗(On Diff #177800)

Should there be a newline at the end of the error message?

eugenis updated this revision to Diff 177802.Dec 11 2018, 4:42 PM

Added newline at the end of the error message.

srhines accepted this revision.Dec 11 2018, 4:56 PM
This revision is now accepted and ready to land.Dec 11 2018, 4:56 PM
rprichard accepted this revision.Dec 11 2018, 6:21 PM
This revision was automatically updated to reflect the committed changes.