This is an archive of the discontinued LLVM Phabricator instance.

[lit]Add llvm-readelf to tool substitutions
ClosedPublic

Authored by jhenderson on Dec 11 2018, 9:29 AM.

Download Raw Diff

Details

Reviewers

courbet
gchatelet
lebedev.ri
rnk
alexander-shaposhnikov

Commits

rG12d190598a70: [lit]Add llvm-readelf to tool substitutions
rL348921: [lit]Add llvm-readelf to tool substitutions

Summary

llvm-readelf was missing from the list of tool substitutions in the lit configuration. This caused no functional issue, because the tools directory is also added to the PATH (why do we do both?), but it did mean that the lit output didn't provide the full path to the llvm-readelf executable, which is useful for rerunning the command outside the test.

Diff Detail

Repository: rL LLVM

Event Timeline

jhenderson created this revision.Dec 11 2018, 9:29 AM

Herald added a subscriber: llvm-commits. · View Herald TranscriptDec 11 2018, 9:29 AM

oh, i see.

This revision is now accepted and ready to land.Dec 11 2018, 9:37 AM

lgtm

Closed by commit rL348921: [lit]Add llvm-readelf to tool substitutions (authored by jhenderson). · Explain WhyDec 12 2018, 2:37 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

test/

lit.cfg.py

10 lines

Diff 177830

llvm/trunk/test/lit.cfg.py

	Show First 20 Lines • Show All 140 Lines • ▼ Show 20 Lines
	# FIXME: Why do we have both `lli` and `%lli` that do slightly different things?			# FIXME: Why do we have both `lli` and `%lli` that do slightly different things?
	tools.extend([			tools.extend([
	'dsymutil', 'lli', 'lli-child-target', 'llvm-ar', 'llvm-as',			'dsymutil', 'lli', 'lli-child-target', 'llvm-ar', 'llvm-as',
	'llvm-bcanalyzer', 'llvm-config', 'llvm-cov', 'llvm-cxxdump', 'llvm-cvtres',			'llvm-bcanalyzer', 'llvm-config', 'llvm-cov', 'llvm-cxxdump', 'llvm-cvtres',
	'llvm-diff', 'llvm-dis', 'llvm-dwarfdump', 'llvm-exegesis', 'llvm-extract',			'llvm-diff', 'llvm-dis', 'llvm-dwarfdump', 'llvm-exegesis', 'llvm-extract',
	'llvm-isel-fuzzer', 'llvm-opt-fuzzer', 'llvm-lib', 'llvm-link', 'llvm-lto',			'llvm-isel-fuzzer', 'llvm-opt-fuzzer', 'llvm-lib', 'llvm-link', 'llvm-lto',
	'llvm-lto2', 'llvm-mc', 'llvm-mca', 'llvm-modextract', 'llvm-nm',			'llvm-lto2', 'llvm-mc', 'llvm-mca', 'llvm-modextract', 'llvm-nm',
	'llvm-objcopy', 'llvm-objdump', 'llvm-pdbutil', 'llvm-profdata',			'llvm-objcopy', 'llvm-objdump', 'llvm-pdbutil', 'llvm-profdata',
	'llvm-ranlib', 'llvm-readobj', 'llvm-rtdyld', 'llvm-size', 'llvm-split',			'llvm-ranlib', 'llvm-readelf', 'llvm-readobj', 'llvm-rtdyld', 'llvm-size',
	'llvm-strings', 'llvm-strip', 'llvm-tblgen', 'llvm-undname', 'llvm-c-test',			'llvm-split', 'llvm-strings', 'llvm-strip', 'llvm-tblgen', 'llvm-undname',
	'llvm-cxxfilt', 'llvm-xray', 'yaml2obj', 'obj2yaml', 'yaml-bench',			'llvm-c-test', 'llvm-cxxfilt', 'llvm-xray', 'yaml2obj', 'obj2yaml',
	'verify-uselistorder', 'bugpoint', 'llc', 'llvm-symbolizer', 'opt',			'yaml-bench', 'verify-uselistorder', 'bugpoint', 'llc', 'llvm-symbolizer',
	'sancov', 'sanstats'])			'opt', 'sancov', 'sanstats'])

	# The following tools are optional			# The following tools are optional
	tools.extend([			tools.extend([
	ToolSubst('llvm-go', unresolved='ignore'),			ToolSubst('llvm-go', unresolved='ignore'),
	ToolSubst('llvm-mt', unresolved='ignore'),			ToolSubst('llvm-mt', unresolved='ignore'),
	ToolSubst('Kaleidoscope-Ch3', unresolved='ignore'),			ToolSubst('Kaleidoscope-Ch3', unresolved='ignore'),
	ToolSubst('Kaleidoscope-Ch4', unresolved='ignore'),			ToolSubst('Kaleidoscope-Ch4', unresolved='ignore'),
	ToolSubst('Kaleidoscope-Ch5', unresolved='ignore'),			ToolSubst('Kaleidoscope-Ch5', unresolved='ignore'),
	▲ Show 20 Lines • Show All 168 Lines • Show Last 20 Lines