Page MenuHomePhabricator

[lit]Add llvm-readelf to tool substitutions
ClosedPublic

Authored by jhenderson on Dec 11 2018, 9:29 AM.

Details

Summary

llvm-readelf was missing from the list of tool substitutions in the lit configuration. This caused no functional issue, because the tools directory is also added to the PATH (why do we do both?), but it did mean that the lit output didn't provide the full path to the llvm-readelf executable, which is useful for rerunning the command outside the test.

Diff Detail

Repository
rL LLVM

Event Timeline

jhenderson created this revision.Dec 11 2018, 9:29 AM
alexshap accepted this revision.Dec 11 2018, 9:37 AM

oh, i see.

This revision is now accepted and ready to land.Dec 11 2018, 9:37 AM
rnk accepted this revision.Dec 11 2018, 1:42 PM

lgtm

This revision was automatically updated to reflect the committed changes.