This is an archive of the discontinued LLVM Phabricator instance.

Differential D55531

AsmParser: test .double NaN
ClosedPublic

Authored by jfb on Dec 10 2018, 3:52 PM.

Details

Reviewers
scanon
rjmccall
Commits
rG1d460eb52e20: AsmParser: test .double NaN and .double inf
rL349376: AsmParser: test .double NaN and .double inf
Summary

It looks like this support was added to match GNU AS, but only tests .float and not .double. I asked RedHat folks to confirm that 0x7fffffffffffffff was indeed the right value.

Diff Detail

Event Timeline

jfb created this revision.Dec 10 2018, 3:52 PM
Herald added subscribers: llvm-commits, dexonsmith, jkorous. · View Herald TranscriptDec 10 2018, 3:52 PM
Harbormaster completed remote builds in B25909: Diff 177610.Dec 10 2018, 3:52 PM
rjmccall added a comment.Dec 11 2018, 6:21 PM

Seems reasonable to me. I think the right approach for validating that this is the right value is to just check some assembler outputs; I can't imagine what other sort of spec would be acceptable.

jfb added a comment.Dec 14 2018, 1:29 PM
In D55531#1327923, @rjmccall wrote:

Seems reasonable to me. I think the right approach for validating that this is the right value is to just check some assembler outputs; I can't imagine what other sort of spec would be acceptable.

Right, that's what I asked the RedHat folks to confirm, and they did.

cameron.mcinally added a subscriber: cameron.mcinally.Dec 14 2018, 1:34 PM
scanon accepted this revision.Dec 17 2018, 10:40 AM

Shrug. OK.

This revision is now accepted and ready to land.Dec 17 2018, 10:40 AM
scanon added a comment.Dec 17 2018, 10:44 AM

Can you also add a check for .double infinity? It looks like that's likely missing too.

jfb updated this revision to Diff 178493.Dec 17 2018, 10:56 AM
  • Also test infinity
Harbormaster completed remote builds in B26071: Diff 178493.Dec 17 2018, 10:56 AM
Closed by commit rL349376: AsmParser: test .double NaN and .double inf (authored by jfb). · Explain WhyDec 17 2018, 10:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
MC/
AsmParser/
3 lines

Diff 177610

test/MC/AsmParser/floating-literals.s

Show All 10 Lines
.single InFinIty .single InFinIty
# CHECK: .long 4286578688 # CHECK: .long 4286578688
.single -iNf .single -iNf
# CHECK: .long 2147483647 # CHECK: .long 2147483647
.single nAN .single nAN
# CHECK: .quad 9223372036854775807
.double NaN
# CHECK: .long 1067928519 # CHECK: .long 1067928519
.float 1.307 .float 1.307
# CHECK: .quad 4617315517961601024 # CHECK: .quad 4617315517961601024
# CHECK: .quad 4597526701198935065 # CHECK: .quad 4597526701198935065
# CHECK: .quad -4600933674317040845 # CHECK: .quad -4600933674317040845
.double 5, .232, -11.1 .double 5, .232, -11.1
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines