This is an archive of the discontinued LLVM Phabricator instance.

Differential D55405

[CMake] Use hidden visibility for static libc++ in Fuchsia
ClosedPublic

Authored by phosek on Dec 6 2018, 6:20 PM.

Details

Reviewers
mcgrathr
EricWF
Commits
rG0f65ac2aeef3: [CMake] Use hidden visibility for static libc++ in Fuchsia
rC350491: [CMake] Use hidden visibility for static libc++ in Fuchsia
rL350491: [CMake] Use hidden visibility for static libc++ in Fuchsia
Summary

This is enables the use of libc++ in contexts such as device drivers.

Diff Detail

Repository
rC Clang

Event Timeline

phosek created this revision.Dec 6 2018, 6:20 PM
Herald added a reviewer: EricWF. · View Herald TranscriptDec 6 2018, 6:20 PM
Herald added subscribers: cfe-commits, mgorny. · View Herald Transcript
phosek added a parent revision: D55404: [libcxx] Support building static library with hidden visibility.Dec 6 2018, 6:20 PM
mcgrathr accepted this revision.Dec 10 2018, 12:57 PM

lgtm

This revision is now accepted and ready to land.Dec 10 2018, 12:57 PM
Closed by commit rL350491: [CMake] Use hidden visibility for static libc++ in Fuchsia (authored by phosek). · Explain WhyJan 6 2019, 12:31 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 6 2019, 12:31 AM

Revision Contents

PathSize
clang/
cmake/
caches/
1 line

Diff 177092

clang/cmake/caches/Fuchsia-stage2.cmake

Show First 20 Lines • Show All 110 Lines • ▼ Show 20 Lines foreach(target x86_64;aarch64)
set(RUNTIMES_${target}-fuchsia_LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXXABI_ENABLE_STATIC_UNWINDER ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXXABI_ENABLE_STATIC_UNWINDER ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXXABI_INSTALL_STATIC_LIBRARY OFF CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXXABI_INSTALL_STATIC_LIBRARY OFF CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY OFF CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY OFF CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXX_USE_COMPILER_RT ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXX_USE_COMPILER_RT ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY OFF CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY OFF CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXX_HIDDEN_VISIBILITY_IN_STATIC_LIBRARY ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "") set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "")
endforeach() endforeach()
set(LLVM_RUNTIME_SANITIZERS "Address" CACHE STRING "") set(LLVM_RUNTIME_SANITIZERS "Address" CACHE STRING "")
set(LLVM_RUNTIME_SANITIZER_Address_TARGETS "x86_64-fuchsia;aarch64-fuchsia" CACHE STRING "") set(LLVM_RUNTIME_SANITIZER_Address_TARGETS "x86_64-fuchsia;aarch64-fuchsia" CACHE STRING "")
endif() endif()
set(LLVM_BUILTIN_TARGETS "${BUILTIN_TARGETS}" CACHE STRING "") set(LLVM_BUILTIN_TARGETS "${BUILTIN_TARGETS}" CACHE STRING "")
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines