Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D55379

[OPENMP][NVPTX]Correct type casting for printf args + simplified shfl64 function.
ClosedPublic
Actions

Authored by ABataev on Dec 6 2018, 11:35 AM.

Details

Reviewers
gtbercea
kkwli0
Commits
rG653e8ba79a00: [OPENMP][NVPTX]Correct type casting for printf args + simplified shfl64…
rL348521: [OPENMP][NVPTX]Correct type casting for printf args + simplified shfl64…
rOMP348521: [OPENMP][NVPTX]Correct type casting for printf args + simplified shfl64…
Summary

Explicitly casted printf's args to the required types + simplified
shfl64 function.

Diff Detail

Event Timeline

ABataev created this revision.Dec 6 2018, 11:35 AM
Herald added subscribers: jfb, guansong. · View Herald TranscriptDec 6 2018, 11:35 AM
Harbormaster completed remote builds in B25781: Diff 177020.Dec 6 2018, 11:35 AM
gtbercea accepted this revision.Dec 6 2018, 11:48 AM

LG

This revision is now accepted and ready to land.Dec 6 2018, 11:48 AM
Closed by commit rOMP348521: [OPENMP][NVPTX]Correct type casting for printf args + simplified shfl64… (authored by ABataev). · Explain WhyDec 6 2018, 11:49 AM
This revision was automatically updated to reflect the committed changes.
kkwli0 added inline comments.Dec 6 2018, 11:52 AM
libomptarget/deviceRTLs/nvptx/src/debug.h
190

Is it still being used?

ABataev marked an inline comment as done.Dec 6 2018, 11:54 AM
ABataev added inline comments.
libomptarget/deviceRTLs/nvptx/src/debug.h
190

I will check this later. Still, there are some places which must be fixed.

hfinkel mentioned this in D62393: [OPENMP][NVPTX]Mark parallel level counter as volatile..Jun 13 2019, 3:01 PM

Revision Contents
Changeset List

PathSize
libomptarget/
deviceRTLs/
nvptx/
src/
4 lines
69 lines
30 lines
8 lines
86 lines
2 lines
14 lines
7 lines
7 lines
4 lines
17 lines

Diff 177020

View Options

libomptarget/deviceRTLs/nvptx/src/cancel.cu

Loading...
View Options

libomptarget/deviceRTLs/nvptx/src/data_sharing.cu

Loading...
View Options

libomptarget/deviceRTLs/nvptx/src/debug.h

Loading...
View Options

libomptarget/deviceRTLs/nvptx/src/libcall.cu

Loading...
View Options

libomptarget/deviceRTLs/nvptx/src/loop.cu

Loading...
View Options

libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu

Loading...
View Options

libomptarget/deviceRTLs/nvptx/src/parallel.cu

Loading...
View Options

libomptarget/deviceRTLs/nvptx/src/reduction.cu

Loading...
View Options

libomptarget/deviceRTLs/nvptx/src/supporti.h

Loading...
View Options

libomptarget/deviceRTLs/nvptx/src/sync.cu

Loading...
View Options

libomptarget/deviceRTLs/nvptx/src/task.cu

Loading...