[WebAssembly] clang-format/clang-tidy AsmParser (NFC)

[aheejin]

Summary

• LLVM clang-format style doesn't allow one-line ifs.
• LLVM clang-tidy style says method names should start with a lowercase letter. But currently WebAssemblyAsmParser's parent class MCTargetAsmParser is mixing lowercase and uppercase method names itself so overridden methods cannot be renamed now.
• Changed else ifs after returns to ifs.
• Added some newlines for readability.

[aheejin]

• Add some newlines

[aheejin]

• clang-tidy

[aheejin]

• remove stray newline

[sbc100]

lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp

440

Adding a newline here before a closing brace seems strange.

[aheejin]

lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp

440

Then in case code is structured like

if (...) {
  ...
else if (...) {
  ...
} else if (...) {
  ...
}
...

And body of each if and else if is long enough so I'd like to add newlines, where should I add them?

[sbc100]

lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp

440

For me that block structure it enough to break it up visually.

To my eye adding newlines at the top of bottom of a block looks strange so I would leave it as is.

In this particular case since we return at the end of each block you could remove the else's completely and make it into a sequence of "if (xxx) { return .. }", but I'm not sure that would help with read-ability in this case.

[aheejin]

• Changed else if to if after returns

[aheejin]

lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp

440

That sounds good. I changed them into ifs and added newlines after. LLVM coding standards say don't use else after a return anyway.

lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp

StringRef ExpectIdent() {
     auto Name = Lexer.getTok().getString();
     Parser.Lex();
     return Name;
   }
 
   Optional<wasm::ValType> ParseType(const StringRef &Type) {
     // FIXME: can't use StringSwitch because wasm::ValType doesn't have a
     // "invalid" value.
-    if (Type == "i32") return wasm::ValType::I32;
-    if (Type == "i64") return wasm::ValType::I64;
-    if (Type == "f32") return wasm::ValType::F32;
-    if (Type == "f64") return wasm::ValType::F64;
+    if (Type == "i32")
+      return wasm::ValType::I32;
+    if (Type == "i64")
+      return wasm::ValType::I64;
+    if (Type == "f32")
+      return wasm::ValType::F32;
+    if (Type == "f64")
+      return wasm::ValType::F64;
     if (Type == "v128" || Type == "i8x16" || Type == "i16x8" ||
         Type == "i32x4" || Type == "i64x2" || Type == "f32x4" ||
-        Type == "f64x2") return wasm::ValType::V128;
+        Type == "f64x2")
+      return wasm::ValType::V128;
     return Optional<wasm::ValType>();
   }
 
   bool ParseRegTypeList(SmallVectorImpl<wasm::ValType> &Types) {
     while (Lexer.is(AsmToken::Identifier)) {
       auto Type = ParseType(Lexer.getTok().getString());
       if (!Type)
         return true;
bool ParseInstruction(ParseInstructionInfo & /*Info*/, StringRef Name,
     // use NameLoc instead.
     Name = StringRef(NameLoc.getPointer(), Name.size());
     // WebAssembly has instructions with / in them, which AsmLexer parses
     // as seperate tokens, so if we find such tokens immediately adjacent (no
     // whitespace), expand the name to include them:
     for (;;) {
       auto &Sep = Lexer.getTok();
       if (Sep.getLoc().getPointer() != Name.end() ||
-          Sep.getKind() != AsmToken::Slash) break;
+          Sep.getKind() != AsmToken::Slash)
+        break;
       // Extend name with /
       Name = StringRef(Name.begin(), Name.size() + Sep.getString().size());
       Parser.Lex();
       // We must now find another identifier, or error.
       auto &Id = Lexer.getTok();
       if (Id.getKind() != AsmToken::Identifier ||
           Id.getLoc().getPointer() != Name.end())
         return Error("Incomplete instruction name: ", Id);
bool ParseDirective(AsmToken DirectiveID) override {
     assert(DirectiveID.getKind() == AsmToken::Identifier);
     auto &Out = getStreamer();
     auto &TOut =
         reinterpret_cast<WebAssemblyTargetStreamer &>(*Out.getTargetStreamer());
     // TODO: any time we return an error, at least one token must have been
     // consumed, otherwise this will not signal an error to the caller.
     if (DirectiveID.getString() == ".globaltype") {
       auto SymName = ExpectIdent();
-      if (SymName.empty()) return true;
-      if (Expect(AsmToken::Comma, ",")) return true;
+      if (SymName.empty())
+        return true;
+      if (Expect(AsmToken::Comma, ","))
+        return true;
       auto TypeTok = Lexer.getTok();
       auto TypeName = ExpectIdent();
-      if (TypeName.empty()) return true;
+      if (TypeName.empty())
+        return true;
       auto Type = ParseType(TypeName);
       if (!Type)
         return Error("Unknown type in .globaltype directive: ", TypeTok);
       // Now set this symbol with the correct type.
       auto WasmSym = cast<MCSymbolWasm>(
-                    TOut.getStreamer().getContext().getOrCreateSymbol(SymName));
       WasmSym->setType(wasm::WASM_SYMBOL_TYPE_GLOBAL);
       WasmSym->setGlobalType(
-            wasm::WasmGlobalType{uint8_t(Type.getValue()), true});
       // And emit the directive again.
       TOut.emitGlobalType(WasmSym);
       return Expect(AsmToken::EndOfStatement, "EOL");
     } else if (DirectiveID.getString() == ".functype") {
       // This code has to send things to the streamer similar to
       // WebAssemblyAsmPrinter::EmitFunctionBodyStart.
       // TODO: would be good to factor this into a common function, but the
       // assembler and backend really don't share any common code, and this code
       // parses the locals seperately.
       auto SymName = ExpectIdent();
-      if (SymName.empty()) return true;
+      if (SymName.empty())
+        return true;
       auto WasmSym = cast<MCSymbolWasm>(
-                    TOut.getStreamer().getContext().getOrCreateSymbol(SymName));
       if (CurrentState == Label && WasmSym == LastLabel) {
         // This .functype indicates a start of a function.
         CurrentState = FunctionStart;
       }
       auto Signature = make_unique<wasm::WasmSignature>();
-      if (Expect(AsmToken::LParen, "(")) return true;
-      if (ParseRegTypeList(Signature->Params)) return true;
-      if (Expect(AsmToken::RParen, ")")) return true;
-      if (Expect(AsmToken::MinusGreater, "->")) return true;
-      if (Expect(AsmToken::LParen, "(")) return true;
-      if (ParseRegTypeList(Signature->Returns)) return true;
-      if (Expect(AsmToken::RParen, ")")) return true;
+      if (Expect(AsmToken::LParen, "("))
+        return true;
+      if (ParseRegTypeList(Signature->Params))
+        return true;
+      if (Expect(AsmToken::RParen, ")"))
+        return true;
+      if (Expect(AsmToken::MinusGreater, "->"))
+        return true;
+      if (Expect(AsmToken::LParen, "("))
+        return true;
+      if (ParseRegTypeList(Signature->Returns))
+        return true;
+      if (Expect(AsmToken::RParen, ")"))
+        return true;
       WasmSym->setSignature(Signature.get());
       addSignature(std::move(Signature));
       WasmSym->setType(wasm::WASM_SYMBOL_TYPE_FUNCTION);
       TOut.emitFunctionType(WasmSym);
       // TODO: backend also calls TOut.emitIndIdx, but that is not implemented.
       return Expect(AsmToken::EndOfStatement, "EOL");
     } else if (DirectiveID.getString() == ".local") {
       if (CurrentState != FunctionStart)
         return Error(".local directive should follow the start of a function",
                      Lexer.getTok());
       SmallVector<wasm::ValType, 4> Locals;
-      if (ParseRegTypeList(Locals)) return true;
+      if (ParseRegTypeList(Locals))
+        return true;
       TOut.emitLocal(Locals);
       CurrentState = FunctionLocals;
       return Expect(AsmToken::EndOfStatement, "EOL");
     }
-    return true;  // We didn't process this directive.
+    return true; // We didn't process this directive.
   }
 
   bool MatchAndEmitInstruction(SMLoc IDLoc, unsigned & /*Opcode*/,
                                OperandVector &Operands, MCStreamer &Out,
                                uint64_t &ErrorInfo,
                                bool MatchingInlineAsm) override {
     MCInst Inst;
     unsigned MatchResult =