Page MenuHomePhabricator

[libcxx] Always enable availability in the lit test suite.
ClosedPublic

Authored by ldionne on Nov 29 2018, 2:54 PM.

Details

Summary

Running the tests without availability enabled doesn't really make sense:
availability annotations allow catching errors at compile-time instead
of link-time. Running the tests without availability enabled allows
confirming that a test breaks at link-time under some configuration,
but it is more useful to instead check that it should fail at compile-time.

Always enabling availability in the lit test suite will greatly simplify
XFAILs and troubleshooting of failing tests, which is currently a giant
pain because we have these two levels of possible failure: link-time and
compile-time.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Nov 29 2018, 2:54 PM

@mclow.lists This should fix the test failures you've been seeing. Would you please kindly test the patch on your system? I've tested the patch under several configurations but I'd like to make sure.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 4 2018, 11:34 AM
This revision was automatically updated to reflect the committed changes.

I'm going to closely monitor potential CI failures. I think only CI on Apple platforms should be affected, but I'll keep an eye out.