This is an archive of the discontinued LLVM Phabricator instance.

Differential D54964

Add test about __builtin_constant_p
ClosedPublic

Authored by MaskRay on Nov 27 2018, 11:28 AM.

Details

Reviewers
rsmith
void
shafik
Commits
rGb74d6368974c: Simplify the __builtin_constant_p test that was used to catch rC347417 failure
rL347895: Simplify the __builtin_constant_p test that was used to catch rC347417 failure
rC347895: Simplify the __builtin_constant_p test that was used to catch rC347417 failure

Diff Detail

Repository
rC Clang

Event Timeline

MaskRay created this revision.Nov 27 2018, 11:28 AM
Herald added subscribers: cfe-commits, kristina. · View Herald TranscriptNov 27 2018, 11:28 AM
Harbormaster completed remote builds in B25394: Diff 175543.Nov 27 2018, 11:29 AM
void accepted this revision.Nov 29 2018, 10:17 AM
This revision is now accepted and ready to land.Nov 29 2018, 10:17 AM
Closed by commit rC347895: Simplify the __builtin_constant_p test that was used to catch rC347417 failure (authored by MaskRay). · Explain WhyNov 29 2018, 10:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
SemaCXX/
7 lines

Diff 175902

test/SemaCXX/constant-expression-cxx1y.cpp

Show First 20 Lines • Show All 1,117 Lines • ▼ Show 20 Lines
}; };
constexpr E e1 = E(); constexpr E e1 = E();
static_assert(e1.x != e1.y, ""); static_assert(e1.x != e1.y, "");
constexpr E e2 = E{0}; constexpr E e2 = E{0};
static_assert(e2.x != e2.y, ""); static_assert(e2.x != e2.y, "");
} // namespace IndirectFields } // namespace IndirectFields
constexpr bool __constant_string_p(const char *__s) { constexpr bool indirect_builtin_constant_p(const char *__s) {
while (__builtin_constant_p(*__s) && *__s)
__s++;
return __builtin_constant_p(*__s); return __builtin_constant_p(*__s);
} }
constexpr bool n = indirect_builtin_constant_p("a");
constexpr bool n = __constant_string_p("a");