This is an archive of the discontinued LLVM Phabricator instance.

Differential D54961

[AArch64] Add command-line option for SSBS
ClosedPublic

Authored by pbarrio on Nov 27 2018, 11:05 AM.

Details

Reviewers
olista01
samparker
aemerson
Commits
rG1a6d6f053d80: [AArch64] Add command-line option for SSBS
rL348142: [AArch64] Add command-line option for SSBS
rC348142: [AArch64] Add command-line option for SSBS
Summary

SSBS (Speculative Store Bypass Safe) is only mandatory from 8.5
onwards but is optional from Armv8.0-A. This patch adds testing for
the ssbs command line option, added to allow enabling the feature
in previous Armv8-A architectures to 8.5.

Diff Detail

Repository
rC Clang

Event Timeline

pbarrio created this revision.Nov 27 2018, 11:05 AM
Herald added subscribers: kristof.beyls, javed.absar. · View Herald TranscriptNov 27 2018, 11:05 AM
Harbormaster completed remote builds in B25392: Diff 175537.Nov 27 2018, 11:06 AM
samparker accepted this revision.Nov 28 2018, 3:43 AM

LGTM

This revision is now accepted and ready to land.Nov 28 2018, 3:43 AM
Closed by commit rC348142: [AArch64] Add command-line option for SSBS (authored by pabbar01). · Explain WhyDec 3 2018, 6:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
Driver/
9 lines

Diff 176388

test/Driver/aarch64-ssbs.c

// RUN: %clang -### -target aarch64-none-none-eabi -march=armv8a+ssbs %s 2>&1 | FileCheck %s
// CHECK: "-target-feature" "+ssbs"
// RUN: %clang -### -target aarch64-none-none-eabi -march=armv8a+nossbs %s 2>&1 | FileCheck %s --check-prefix=NOSSBS
// NOSSBS: "-target-feature" "-ssbs"
// RUN: %clang -### -target aarch64-none-none-eabi %s 2>&1 | FileCheck %s --check-prefix=ABSENTSSBS
// ABSENTSSBS-NOT: "-target-feature" "+ssbs"
// ABSENTSSBS-NOT: "-target-feature" "-ssbs"