Page MenuHomePhabricator

[compiler-rt] Use exact spelling when building for default target
ClosedPublic

Authored by phosek on Nov 15 2018, 7:58 PM.

Details

Summary

When building for default target only, use exact target spelling
when deriving the name for the per-target runtime directory. This
is necessary for AArch32 where the CMake build by default rewrites
the architecture which leads to unexpected results.

Diff Detail

Event Timeline

phosek created this revision.Nov 15 2018, 7:58 PM
Herald added subscribers: Restricted Project, llvm-commits, mgorny and 2 others. · View Herald TranscriptNov 15 2018, 7:58 PM
mcgrathr accepted this revision.Nov 15 2018, 8:03 PM

lgtm with a comment in the code

compiler-rt/cmake/Modules/CompilerRTUtils.cmake
340

merits a comment

This revision is now accepted and ready to land.Nov 15 2018, 8:03 PM
phosek updated this revision to Diff 174320.Nov 15 2018, 8:15 PM
phosek marked an inline comment as done.
This revision was automatically updated to reflect the committed changes.