Page MenuHomePhabricator

Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/
ClosedPublic

Authored by saugustine on Nov 13 2018, 1:19 PM.

Details

Reviewers
echristo
MaskRay
Summary

Notify the linker when a TU compiled with split-stack
has a function without a prologue.

Diff Detail

Event Timeline

saugustine created this revision.Nov 13 2018, 1:19 PM
saugustine retitled this revision from Notify the linker when a TU compiled with split-stack has a function without a prologue. There is more context here: https://go-review.googlesource.com/c/go/+/148819/ to Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/.Nov 13 2018, 1:25 PM
saugustine added reviewers: echristo, MaskRay.

Add a test case.

echristo accepted this revision.Nov 26 2018, 3:20 PM

LGTM.

lib/Target/ARM/ARMFrameLowering.cpp
2166

FTR the casing on NosplitStack here really bugs me, but it's not your fault and can be updated later :)

This revision is now accepted and ready to land.Nov 26 2018, 3:20 PM

Committed as r347614.

saugustine closed this revision.Nov 26 2018, 3:29 PM