This is an archive of the discontinued LLVM Phabricator instance.

[AsmPrinter] Rename a comment of .gdb_index entry
ClosedPublic

Authored by MaskRay on Nov 13 2018, 10:31 AM.

Details

Summary

The comment refers to the property as "Kind:". However, in gdb,

https://sourceware.org/gdb//onlinedocs/gdb/Index-Section-Format.html names it "attributes",
gdb/dwarf2read.c:dw2_symtab_iter_next refers to the whole value as "cu_index_and_attrs"

Change it to Attributes: for consistency.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Nov 13 2018, 10:31 AM
dblaikie accepted this revision.Nov 13 2018, 11:43 AM

Sounds good to me. Where possible it's great to quote the specs more than the source code - did you happen across any spec for gnu_pubnames themselves? Or only the gdb-index they're used to create (& that's good too - having consistency of naming between gnu_pubnames and gdb_index certainly helps)

This revision is now accepted and ready to land.Nov 13 2018, 11:43 AM
MaskRay updated this revision to Diff 173907.Nov 13 2018, 12:13 PM
MaskRay edited the summary of this revision. (Show Details)

Update description

This revision was automatically updated to reflect the committed changes.