Add an optional argument to expand tildes in the path to mirror llvm's
implementation of the corresponding function.
Apparently this change is more controversial than I thought, so happy
to discuss alternatives here.
I'm not sure this is true. It the overlay specifies a different home directory (this functionality doesn't exist yet) it should take that one, otherwise it should defer to the underlying one.
- implementing this is a substantial burden on VFSes, many of which (by their nature) live out-of-tree. It's not clear what the consequences of ignoring the parameter are, and what callers can expect.
- use of optional-args in virtual methods would be nice to avoid
- the use of boolean params like this in general doesn't scale well
Would a separate method address those 3 concerns? My goal was to keep things simple and mirror llvm's API, which helps with migrating between the two. I don't have a strong opinion on this though, as long as the functionality is available.
Happy to help with review if you do want to move forward with this!
Thanks, I look forward to your input!
Thanks for sending this!
I think fs::real_path isn't a great precedent to be following here, but
that we can put the same functionality behind a slightly different API.
I may well be missing requirements, details, or historical context here.
Hopefully you or someone can correct me if so!