This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Don't show all refs results if -name is ambiguous in dexp.
ClosedPublic

Authored by hokein on Nov 12 2018, 8:35 AM.

Reviewers

Commits

This revision is now accepted and ready to land.Nov 12 2018, 8:39 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

clang-tools-extra/

trunk/

clangd/

index/

dex/

dexp/

6 lines

Show First 20 Lines • Show All 212 Lines • ▼ Show 20 Lines	if (ID.getNumOccurrences()) {
auto SID = SymbolID::fromStr(ID);		auto SID = SymbolID::fromStr(ID);
if (!SID) {		if (!SID) {
outs() << toString(SID.takeError()) << "\n";		outs() << toString(SID.takeError()) << "\n";
return;		return;
}		}
IDs.push_back(*SID);		IDs.push_back(*SID);
} else {		} else {
IDs = getSymbolIDsFromIndex(Name, Index);		IDs = getSymbolIDsFromIndex(Name, Index);
		if (IDs.size() > 1) {
		outs() << formatv("The name {0} is ambiguous, found {1} different "
		"symbols. Please use id flag to disambiguate.\n",
		Name, IDs.size());
		return;
		}
}		}
RefsRequest RefRequest;		RefsRequest RefRequest;
RefRequest.IDs.insert(IDs.begin(), IDs.end());		RefRequest.IDs.insert(IDs.begin(), IDs.end());
Regex RegexFilter(Filter);		Regex RegexFilter(Filter);
Index->refs(RefRequest, [&RegexFilter](const Ref &R) {		Index->refs(RefRequest, [&RegexFilter](const Ref &R) {
auto U = URI::parse(R.Location.FileURI);		auto U = URI::parse(R.Location.FileURI);
if (!U) {		if (!U) {
outs() << U.takeError();		outs() << U.takeError();
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines