[clangd] Allow symbols from AnyScope in dexp.

[hokein]

Summary

We should allow symbols from any scope in dexp results, othewise
find StringRef doesn't return any results (llvm::StringRef).

[ioeric]

clangd/index/dex/dexp/Dexp.cpp

55 ↗

(On Diff #173673)

I don't think you would want AnyScope here. For example, if QualifiedName is std::string, you can also get llvm::StringRef in the results.

138 ↗

(On Diff #173673)

I think what you actually want is Request.AnyScope = Scopes.empty()? It doesn't seem useful to set AnyScope when scopes are provided.

[hokein]

Address comments.

[hokein]

clangd/index/dex/dexp/Dexp.cpp

55 ↗

(On Diff #173673)

Yeah, the input is required qualified name, I misthought that we can use unqualified name.

clang-tools-extra/trunk/clangd/index/dex/dexp/Dexp.cpp

void run() override {
     FuzzyFindRequest Request;
     Request.Limit = Limit;
     Request.Query = Query;
     if (Scopes.getNumOccurrences() > 0) {
       SmallVector<StringRef, 8> Scopes;
       StringRef(this->Scopes).split(Scopes, ',');
       Request.Scopes = {Scopes.begin(), Scopes.end()};
     }
+    Request.AnyScope = Request.Scopes.empty();
     // FIXME(kbobyrev): Print symbol final scores to see the distribution.
     static const auto OutputFormat = "{0,-4} | {1,-40} | {2,-25}\n";
     outs() << formatv(OutputFormat, "Rank", "Symbol ID", "Symbol Name");
     size_t Rank = 0;
     Index->fuzzyFind(Request, [&](const Symbol &Sym) {
       outs() << formatv(OutputFormat, Rank++, Sym.ID.str(), Sym.Name);
     });
   }