Page MenuHomePhabricator

[clangd] Drop namespace references in the index.
ClosedPublic

Authored by hokein on Nov 7 2018, 5:03 AM.

Details

Summary

Namespace references is less useful compared with other symbols, and
they contribute large part of the index. This patch drops them.
The number of refs is reduced from 5.4 million to 4.7 million.

BeforeAfter
file size78 MB71MB
memory330MB300MB

Diff Detail

Repository
rL LLVM

Event Timeline

hokein created this revision.Nov 7 2018, 5:03 AM
hokein updated this revision to Diff 172926.Nov 7 2018, 5:05 AM

Fix a typo.

kadircet added inline comments.Nov 7 2018, 5:07 AM
clangd/index/SymbolCollector.cpp
359 ↗(On Diff #172926)

Why not handle in shouldCollectSymbol ?

clangd/index/SymbolCollector.h
60 ↗(On Diff #172926)

another typo anbd -> and

sammccall accepted this revision.Nov 7 2018, 6:03 AM
This revision is now accepted and ready to land.Nov 7 2018, 6:03 AM
hokein updated this revision to Diff 172950.Nov 7 2018, 6:58 AM
hokein marked an inline comment as done.

Fix another typo.

hokein added inline comments.Nov 7 2018, 6:58 AM
clangd/index/SymbolCollector.cpp
359 ↗(On Diff #172926)

shouldCollectSymbol is shared between the code collecting symbols and the code collecting references, we still want to collect namespace symbols.

This revision was automatically updated to reflect the committed changes.