This is an archive of the discontinued LLVM Phabricator instance.

Split getpwent and fgetgrent functions in interceptors
ClosedPublic

Authored by krytarowski on Nov 2 2018, 11:11 AM.

Details

Summary

NetBSD does not ship with fgetpwent_r() and fgetgrent_r().
Split their interceptors from getpwent_r() and getgrent_r()
and disable for this OS.

Installation of supernumerary interceptors causes leaking of
errors to dlsym(3)-like operations.

No functional change for other OSes.

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski created this revision.Nov 2 2018, 11:11 AM
vitalybuka added inline comments.Nov 2 2018, 11:25 AM
lib/sanitizer_common/sanitizer_platform_interceptors.h
211

Now you intercept SANITIZER_INTERCEPT_FGETGRENT_R on SI_MAC
Title claims no changes for other oses

Remove unwanted SI_MAC.

This revision is now accepted and ready to land.Nov 2 2018, 1:24 PM
This revision was automatically updated to reflect the committed changes.