As requested by @filcab in https://reviews.llvm.org/D50251#1280267
Details
- Reviewers
filcab vsk vitalybuka - Group Reviewers
Restricted Project - Commits
- rGa0457c02b3e7: [NFC][compiler-rt] Cleanup Implicit Conversion Sanitizer tests to use sized…
rL345661: [NFC][compiler-rt] Cleanup Implicit Conversion Sanitizer tests to use sized…
rCRT345661: [NFC][compiler-rt] Cleanup Implicit Conversion Sanitizer tests to use sized…
Diff Detail
- Repository
- rCRT Compiler Runtime
Event Timeline
Looks good, thank you. Ideally, we'd have different names on those functions, but unless you have a script that generates this and is very easy to change, I'm ok with keeping them as they are.
LGTM
Thanks for working on this!
Filipe
Ideally, we'd have different names on those functions, but unless you have a script that generates this and is very easy to change,
It's super easy to change using mass search-and-replace, but i actually intentionally kept the *function names* as-is,
to be in sync with the clang codegen tests.
I'm ok with keeping them as they are.
LGTM
Feel like actually marking these two reviews as accepted? :)
Thanks for working on this!
Filipe
test/fuzzer/ImplicitIntegerSignChangeTest.cpp | ||
---|---|---|
13 | Could you please clang format it with something like |
Some formatting nitpicking.
test/fuzzer/ImplicitIntegerSignChangeTest.cpp | ||
---|---|---|
13 | That completely messes up all the check-lines here. |
Thank you for the review!
But please make sure Vitaly is happy with the clang-format stuff.
Sure.
I did end up running clang-format, and other than messing up the check-lines,
it didn't do any other (other than those i just applied in the last update here) changes.
Could you please clang format it with something like
git clang-format -f --style=file --extensions=inc,cc,h,c,cpp HEAD^