[libc++] Support newlib as libc++'s C library [locale part]

[jroelofs]

Summary

I'm going to split out @jfb's original patch into three separate ones to lubricate the review process:

• locale stuff
• cmath stuff
• classic_table & ctype mask stuff

This patch covers the first one.

[jroelofs]

+cfe-commits

[mclow.lists]

A general comment: How much of this file is the same as $LIBCXX/include/support/bionic/bionic_locale.h, and would it be beneficial/desirable to create a file that stubs out the locale routines and share it between those two implementations.

Other than that, this looks pretty good.
I like the lack of damage to <locale> a lot.

[mclow.lists]

include/support/newlib/xlocale.h

65

Comment lost the first time. Sigh.

this should be written as:

`static inline int isdigit_l(char c, locale_t)`

You can't use the second parameter if you don't name it.

[jfb]

include/locale

197

This is only done in .cpp files, putting it here means it leaks to users.

include/support/newlib/xlocale.h

28

It's only guarded out if __STRICT_ANSI__, which seems correct? It's a C extension AFAICT, it's not in C11.

isascii.c defines it as return return c >= 0 && c< 128; unconditionally, so it should still be linked in?

65

Cleaner to just not give a name to locale_t l here and below instead of (void) l;?

[danalbert]

include/locale

197

newlib's sys/cdefs.h seems to do this anyway. Talking with jroelofs on IRC, he's going to see if we can skip this check by changing newlib's sys/cdefs.h to #define some way to identify as newlib (that's where other libcs provide such a definition).

include/support/newlib/xlocale.h

37

Can't use nullptr here (need to be able to include from pre-C++11 code).

[jroelofs]

Yeah, it would be better to share the implementation of these between android and newlib. Where's the right place to put that kind of shared thing?

include/support/newlib/xlocale.h

65

Yeah.. brainfart.

[jroelofs]

include/support/newlib/xlocale.h

37

Good point. I'll change that to NULL for the time being.

In a separate patch I've got some "healthier" stubs which fix a few of the libc++ tests that want the C locale (i.e. localization/locales/locale/locale.statics/classic.pass.cpp ).

[jroelofs]

include/support/newlib/xlocale.h

37

The failure being the:

terminating with uncaught exception of type std::runtime_error: collate_byname<char>::collate_byname failed to construct for C

one.

[danalbert]

include/support/newlib/xlocale.h

37

Good idea. iirc even the basic streams don't work if the implementation can't support the C locale.

[mclow.lists]

include/support/newlib/xlocale.h

37

Note that libc++ emulates nullptr in C++03 mode.

67

Should all of these explicitly specify the global namespace?

return ::isdigit(c);

That's not good if isdigit is a macro, but I don't know if that is true for newlib.

[jroelofs]

include/support/newlib/xlocale.h

67

All of these are implemented as macros in newlib.

[jroelofs]

Share implementation with android.

[jroelofs]

Pasted the wrong diff. Ignore the most recent one.

[jfb]

include/locale

197

I still don't think __has_include should be defined in a header, could you put a TODO about fixing the issue in newlib first?

include/support/newlib/xlocale.h

28

As noted before, I think newlib is correct here.

65

Should this be after you terminate the extern "C"?

[jroelofs]

Again, pasted the wrong diff. Ignore the most recent one.

[danalbert]

include/support/xlocale/xlocale.h

2

Can delete the android one and fix up the #includes now, right?

[jroelofs]

Here's the actual "share with android" update.

[jroelofs]

include/support/xlocale/xlocale.h

165

Note that the type of base changed here. locale_bionic.h got this wrong before, and likewise for the other three.

[jfb]

include/support/newlib/xlocale.h

28

isascii ins't in C++11 either :-)

Should libc++ not use it at all, or use a special __isascii?

60

typo

[jroelofs]

include/locale

197

Discussion with newlib folks suggests that this check and include isn't necessary at all as ctime includes time.h which includes _ansi.h, which includes newlib.h. They might be convinced to add NEWLIB to sys/cdefs.h, but until then, we can get by with dropping this part of the patch.

[jfb]

include/locale

197

The thread:

https://sourceware.org/ml/newlib/2014/msg00455.html

This sounds good to me, though it might be an issue in headers where we try to minimize the number/size of headers included (locale is OK, but others may need _NEWLIB_VERSION and have to have an extra include until the newlib fix comes).

[jroelofs]

include/locale

195

Upstream Newlib fixed this in https://sourceware.org/ml/newlib-cvs/2014-q3/msg00038.html

include/support/newlib/xlocale.h

28

Not using it would mean lots of ugly newlib specific stuff in locale.cpp and __locale. Sounds like inline int __isascii(int c) { int isascii(int); return isascii(c); } is the way to go here.

60

good catch

[jfb]

include/locale

202

Can't you drop the above since ctime indirectly includes newlib.h already in the current version of newlib?

include/support/newlib/xlocale.h

28

Would you just leave __isascii in this header? Or fix the rest of libc++ and move it to a global header? That'll be tricky because at least glibc has #define __isascii(c).

[jroelofs]

s/isascii/__isascii/ along with appropriate shims in include/support because isascii isn't supposed to be part of C++.

On second thought, this probably breaks OSX and any other platform that doesn't have support shims. I'm not sure of the best way to proceed on that.

[jroelofs]

include/support/newlib/xlocale.h

28

Oh. Yucky. __libcpp_isascii it is then....

[jroelofs]

libcpp_isascii, rather than isascii

[jfb]

include/__locale

44 ↗

(On Diff #13806)

Could you add a comment explaining this?

Also, it relies on the C library actually exporting isascii, which it would as long as it has non-strict extensions. I think it's a fair assumption, but still worth pointing out.

Shouldn't the forward declaration be extern "C"? If it's found at link time and not in a header then the current code won't work.

include/support/newlib/xlocale.h

31

Remove.

63

Typo still there.

[jroelofs]

include/__locale

44 ↗

(On Diff #13806)

Humph. I'm not sure I can extern "C" the inner declaration. I think I have to give that linkage to the whole thing.

include/support/newlib/xlocale.h

31

oops

63

oops

[jroelofs]

Address comments.

[jfb]

I'm ready to sign off on this after the typos are fixed, but I'd like someone like @mclow.lists to chime in since the __libcpp_isascii thing is kind of ugly (but I don't see a better way).

include/__locale

44 ↗

(On Diff #13809)

Two typos :)

include/locale

199

FWIW newlib has yearly releases around Christmas time, so "a bit" may be "quite a bit" ;-)

[jroelofs]

Fiiiix typos

[mclow.lists]

It is kind of ugly; and I worry about isascii being a macro.
Do any libraries do that?

[mclow.lists]

Note: I'm not objecting because it's ugly; the name is fine.

[joerg]

Why don't we fix the real problem first and stop bothering with the symptoms. The isascii checks break the masks for any char with high bit set. We should IMO have a templated function map2index or so. Then we get:

size_t map2index<char>(char_type a) { return (unsigned char)a; }
size_t map2index<wchar_t>(char_type a) { return a; }

[jroelofs]

It looks like SunOS's isascii is a macro: http://docs.oracle.com/cd/E19683-01/816-0213/6m6ne383q/index.html

@joerg For the ctype<char> ones, I think that's fine, but I don't think that works for ctype<wchar_t> because classic_table has only at least 256 entries. That would get isascii out of include/__locale, and we can leave the ones in src/locale.cpp, which solves this messiness.

include/locale

199

oh boy, yeah. I didn't know their release schedule was that infrequent :)

[danalbert]

In D5385#46, @jroelofs wrote:

@joerg For the ctype<char> ones, I think that's fine, but I don't think that works for ctype<wchar_t> because classic_table has only at least 256 entries. That would get isascii out of include/__locale, and we can leave the ones in src/locale.cpp, which solves this messiness.

ctype<T>::classic_table() is only defined for ctype<char>. We do perform these same checks in ctype<wchar_t>::do_is() though... I'm not sure what the rules are for classifying wide characters... Shouldn't we just be passing these down to the C library's iswupper() and friends as we do in ctype_byname<wchar_t>::do_is()?

[jroelofs]

This time without the isascii part... we can attack that in another patch.

[jfb]

Thanks for splitting. This is all non-contentious as far as I can tell, so I think it's ready to go.

[jroelofs]

r218144

include/locale

 #include <iterator>
 #include <limits>
 #ifndef __APPLE__
 #include <cstdarg>
 #endif
 #include <cstdlib>
 #include <ctime>
 #if defined(_LIBCPP_MSVCRT) || defined(__MINGW32__)
 #include <support/win32/locale_win32.h>
+#elif defined(_NEWLIB_VERSION)
+// FIXME: replace all the uses of _NEWLIB_VERSION with __NEWLIB__ preceded by an
+// include of <sys/cdefs.h> once https://sourceware.org/ml/newlib-cvs/2014-q3/msg00038.html
+// has had a chance to bake for a bit
+#include <support/newlib/xlocale.h>
 #elif !defined(__ANDROID__)
 #include <nl_types.h>
 #endif
 
 #ifdef __APPLE__
 #include <Availability.h>
 #endif
 
 #include <__undef_min_max>
 

 typedef _VSTD::unique_ptr<__locale_struct, decltype(&freelocale)> __locale_unique_ptr;
 #ifndef _LIBCPP_LOCALE__L_EXTENSIONS
 typedef _VSTD::unique_ptr<__locale_struct, decltype(&uselocale)> __locale_raii;
 #endif
 
 // OSX has nice foo_l() functions that let you turn off use of the global
 // locale.  Linux, not so much.  The following functions avoid the locale when
 // that's possible and otherwise do the wrong thing.  FIXME.
-#if defined(__linux__) || defined(__EMSCRIPTEN__) || defined(_AIX)
+#if defined(__linux__) || defined(__EMSCRIPTEN__) || defined(_AIX) || \
+    defined(_NEWLIB_VERSION)
 
 #ifdef _LIBCPP_LOCALE__L_EXTENSIONS
 decltype(MB_CUR_MAX_L(_VSTD::declval<locale_t>()))
 inline _LIBCPP_INLINE_VISIBILITY
 __mb_cur_max_l(locale_t __l)
 {
   return MB_CUR_MAX_L(__l);
 }

 template <class _CharT>
 locale::id
 messages<_CharT>::id;
 
 template <class _CharT>
 typename messages<_CharT>::catalog
 messages<_CharT>::do_open(const basic_string<char>& __nm, const locale&) const
 {
-#if defined(_WIN32) || defined(__ANDROID__)
+#if defined(_WIN32) || defined(__ANDROID__) || defined(_NEWLIB_VERSION)
     return -1;
 #else // _WIN32 || __ANDROID__
     catalog __cat = (catalog)catopen(__nm.c_str(), NL_CAT_LOCALE);
     if (__cat != -1)
         __cat = static_cast<catalog>((static_cast<size_t>(__cat) >> 1));
     return __cat;
 #endif // _WIN32 || __ANDROID__
 }
 
 template <class _CharT>
 typename messages<_CharT>::string_type
 messages<_CharT>::do_get(catalog __c, int __set, int __msgid,
                          const string_type& __dflt) const
 {
-#if defined(_WIN32) || defined(__ANDROID__)
+#if defined(_WIN32) || defined(__ANDROID__) || defined(_NEWLIB_VERSION)
     return __dflt;
 #else // _WIN32
     string __ndflt;
     __narrow_to_utf8<sizeof(char_type)*__CHAR_BIT__>()(back_inserter(__ndflt),
                                                        __dflt.c_str(),
                                                        __dflt.c_str() + __dflt.size());
     if (__c != -1)
         __c <<= 1;
     nl_catd __cat = (nl_catd)__c;
     char* __n = catgets(__cat, __set, __msgid, __ndflt.c_str());
     string_type __w;
     __widen_from_utf8<sizeof(char_type)*__CHAR_BIT__>()(back_inserter(__w),
                                                         __n, __n + strlen(__n));
     return __w;
 #endif // _WIN32
 }
 
 template <class _CharT>
 void
 messages<_CharT>::do_close(catalog __c) const
 {
-#if !defined(_WIN32) && !defined(__ANDROID__)
+#if !defined(_WIN32) && !defined(__ANDROID__) && !defined(_NEWLIB_VERSION)
     if (__c != -1)
         __c <<= 1;
     nl_catd __cat = (nl_catd)__c;
     catclose(__cat);
 #endif // !_WIN32
 }
 
 _LIBCPP_EXTERN_TEMPLATE2(class _LIBCPP_TYPE_VIS messages<char>)

include/support/android/locale_bionic.h

 
 #ifdef __cplusplus
 extern "C" {
 #endif
 
 #include <stdlib.h>
 #include <xlocale.h>
 
-static inline int isalnum_l(int c, locale_t) {
-  return isalnum(c);
-}
-
-static inline int isalpha_l(int c, locale_t) {
-  return isalpha(c);
-}
-
-static inline int isblank_l(int c, locale_t) {
-  return isblank(c);
-}
-
-static inline int iscntrl_l(int c, locale_t) {
-  return iscntrl(c);
-}
-
-static inline int isdigit_l(int c, locale_t) {
-  return isdigit(c);
-}
-
-static inline int isgraph_l(int c, locale_t) {
-  return isgraph(c);
-}
-
-static inline int islower_l(int c, locale_t) {
-  return islower(c);
-}
-
-static inline int isprint_l(int c, locale_t) {
-  return isprint(c);
-}
-
-static inline int ispunct_l(int c, locale_t) {
-  return ispunct(c);
-}
-
-static inline int isspace_l(int c, locale_t) {
-  return isspace(c);
-}
-
-static inline int isupper_l(int c, locale_t) {
-  return isupper(c);
-}
-
-static inline int isxdigit_l(int c, locale_t) {
-  return isxdigit(c);
-}
-
-static inline int iswalnum_l(wint_t c, locale_t) {
-  return iswalnum(c);
-}
-
-static inline int iswalpha_l(wint_t c, locale_t) {
-  return iswalpha(c);
-}
-
-static inline int iswblank_l(wint_t c, locale_t) {
-  return iswblank(c);
-}
-
-static inline int iswcntrl_l(wint_t c, locale_t) {
-  return iswcntrl(c);
-}
-
-static inline int iswdigit_l(wint_t c, locale_t) {
-  return iswdigit(c);
-}
-
-static inline int iswgraph_l(wint_t c, locale_t) {
-  return iswgraph(c);
-}
-
-static inline int iswlower_l(wint_t c, locale_t) {
-  return iswlower(c);
-}
-
-static inline int iswprint_l(wint_t c, locale_t) {
-  return iswprint(c);
-}
-
-static inline int iswpunct_l(wint_t c, locale_t) {
-  return iswpunct(c);
-}
-
-static inline int iswspace_l(wint_t c, locale_t) {
-  return iswspace(c);
-}
-
-static inline int iswupper_l(wint_t c, locale_t) {
-  return iswupper(c);
-}
-
-static inline int iswxdigit_l(wint_t c, locale_t) {
-  return iswxdigit(c);
-}
-
-static inline int toupper_l(int c, locale_t) {
-  return toupper(c);
-}
-
-static inline int tolower_l(int c, locale_t) {
-  return tolower(c);
-}
-
-static inline int towupper_l(int c, locale_t) {
-  return towupper(c);
-}
-
-static inline int towlower_l(int c, locale_t) {
-  return towlower(c);
-}
-
-static inline int strcoll_l(const char *s1, const char *s2, locale_t) {
-  return strcoll(s1, s2);
-}
-
-static inline size_t strxfrm_l(char *dest, const char *src, size_t n,
-                               locale_t) {
-  return strxfrm(dest, src, n);
-}
-
-static inline size_t strftime_l(char *s, size_t max, const char *format,
-                                const struct tm *tm, locale_t) {
-  return strftime(s, max, format, tm);
-}
-
-static inline int wcscoll_l(const wchar_t *ws1, const wchar_t *ws2, locale_t) {
-  return wcscoll(ws1, ws2);
-}
-
-static inline size_t wcsxfrm_l(wchar_t *dest, const wchar_t *src, size_t n,
-                               locale_t) {
-  return wcsxfrm(dest, src, n);
-}
-
-static inline long double strtold_l(const char *nptr, char **endptr, locale_t) {
-  return strtold(nptr, endptr);
-}
-
-static inline long long strtoll_l(const char *nptr, char **endptr, size_t base,
-                                  locale_t) {
-  return strtoll(nptr, endptr, base);
-}
-
-static inline unsigned long long strtoull_l(const char *nptr, char **endptr,
-                                            size_t base, locale_t) {
-  return strtoull(nptr, endptr, base);
-}
-
-static inline long long wcstoll_l(const wchar_t *nptr, wchar_t **endptr,
-                                  size_t base, locale_t) {
-  return wcstoll(nptr, endptr, base);
-}
-
-static inline unsigned long long wcstoull_l(const wchar_t *nptr,
-                                            wchar_t **endptr, size_t base,
-                                            locale_t) {
-  return wcstoull(nptr, endptr, base);
-}
-
-static inline long double wcstold_l(const wchar_t *nptr, wchar_t **endptr,
-                                    locale_t) {
-  return wcstold(nptr, endptr);
-}
-
 #ifdef __cplusplus
 }
 #endif
+
+// Share implementation with Newlib
+#include <support/xlocale/xlocale.h>
+
 #endif // defined(__ANDROID__)
 #endif // _LIBCPP_SUPPORT_ANDROID_LOCALE_BIONIC_H

include/support/newlib/xlocale.h

+//===----------------------------------------------------------------------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef _LIBCPP_SUPPORT_NEWLIB_XLOCALE_H
+#define _LIBCPP_SUPPORT_NEWLIB_XLOCALE_H
+
+#if defined(_NEWLIB_VERSION)
+
+#include <cstdlib>
+#include <clocale>
+#include <cwctype>
+#include <ctype.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+// Patch over newlib's lack of extended locale support
+typedef void *locale_t;
+static inline locale_t duplocale(locale_t) {
+  return NULL;
+}
+
+static inline void freelocale(locale_t) {
+}
+
+static inline locale_t newlocale(int, const char *, locale_t) {
+  return NULL;
+}
+
+static inline locale_t uselocale(locale_t) {
+  return NULL;
+}
+
+#define LC_COLLATE_MASK  (1 << LC_COLLATE)
+#define LC_CTYPE_MASK    (1 << LC_CTYPE)
+#define LC_MESSAGES_MASK (1 << LC_MESSAGES)
+#define LC_MONETARY_MASK (1 << LC_MONETARY)
+#define LC_NUMERIC_MASK  (1 << LC_NUMERIC)
+#define LC_TIME_MASK     (1 << LC_TIME)
+#define LC_ALL_MASK (LC_COLLATE_MASK|\
+                     LC_CTYPE_MASK|\
+                     LC_MONETARY_MASK|\
+                     LC_NUMERIC_MASK|\
+                     LC_TIME_MASK|\
+                     LC_MESSAGES_MASK)
+
+// Share implementation with Android's Bionic
+#include <support/xlocale/xlocale.h>
+
+#ifdef __cplusplus
+} // extern "C"
+#endif
+
+#endif // _NEWLIB_VERSION
+
+#endif

include/support/xlocale/xlocale.h

+// -*- C++ -*-
+//===------------------- support/xlocale/xlocale.h ------------------------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+// This is a shared implementation of a shim to provide extended locale support
+// on top of libc's that don't support it (like Android's bionic, and Newlib).
+//
+// The 'illusion' only works when the specified locale is "C" or "POSIX", but
+// that's about as good as we can do without implementing full xlocale support
+// in the underlying libc.
+//===----------------------------------------------------------------------===//
+
+#ifndef _LIBCPP_SUPPORT_XLOCALE_XLOCALE_H
+#define _LIBCPP_SUPPORT_XLOCALE_XLOCALE_H
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+static inline int isalnum_l(int c, locale_t) {
+  return isalnum(c);
+}
+
+static inline int isalpha_l(int c, locale_t) {
+  return isalpha(c);
+}
+
+static inline int isblank_l(int c, locale_t) {
+  return isblank(c);
+}
+
+static inline int iscntrl_l(int c, locale_t) {
+  return iscntrl(c);
+}
+
+static inline int isdigit_l(int c, locale_t) {
+  return isdigit(c);
+}
+
+static inline int isgraph_l(int c, locale_t) {
+  return isgraph(c);
+}
+
+static inline int islower_l(int c, locale_t) {
+  return islower(c);
+}
+
+static inline int isprint_l(int c, locale_t) {
+  return isprint(c);
+}
+
+static inline int ispunct_l(int c, locale_t) {
+  return ispunct(c);
+}
+
+static inline int isspace_l(int c, locale_t) {
+  return isspace(c);
+}
+
+static inline int isupper_l(int c, locale_t) {
+  return isupper(c);
+}
+
+static inline int isxdigit_l(int c, locale_t) {
+  return isxdigit(c);
+}
+
+static inline int iswalnum_l(wint_t c, locale_t) {
+  return iswalnum(c);
+}
+
+static inline int iswalpha_l(wint_t c, locale_t) {
+  return iswalpha(c);
+}
+
+static inline int iswblank_l(wint_t c, locale_t) {
+  return iswblank(c);
+}
+
+static inline int iswcntrl_l(wint_t c, locale_t) {
+  return iswcntrl(c);
+}
+
+static inline int iswdigit_l(wint_t c, locale_t) {
+  return iswdigit(c);
+}
+
+static inline int iswgraph_l(wint_t c, locale_t) {
+  return iswgraph(c);
+}
+
+static inline int iswlower_l(wint_t c, locale_t) {
+  return iswlower(c);
+}
+
+static inline int iswprint_l(wint_t c, locale_t) {
+  return iswprint(c);
+}
+
+static inline int iswpunct_l(wint_t c, locale_t) {
+  return iswpunct(c);
+}
+
+static inline int iswspace_l(wint_t c, locale_t) {
+  return iswspace(c);
+}
+
+static inline int iswupper_l(wint_t c, locale_t) {
+  return iswupper(c);
+}
+
+static inline int iswxdigit_l(wint_t c, locale_t) {
+  return iswxdigit(c);
+}
+
+static inline int toupper_l(int c, locale_t) {
+  return toupper(c);
+}
+
+static inline int tolower_l(int c, locale_t) {
+  return tolower(c);
+}
+
+static inline int towupper_l(int c, locale_t) {
+  return towupper(c);
+}
+
+static inline int towlower_l(int c, locale_t) {
+  return towlower(c);
+}
+
+static inline int strcoll_l(const char *s1, const char *s2, locale_t) {
+  return strcoll(s1, s2);
+}
+
+static inline size_t strxfrm_l(char *dest, const char *src, size_t n,
+                               locale_t) {
+  return strxfrm(dest, src, n);
+}
+
+static inline size_t strftime_l(char *s, size_t max, const char *format,
+                                const struct tm *tm, locale_t) {
+  return strftime(s, max, format, tm);
+}
+
+static inline int wcscoll_l(const wchar_t *ws1, const wchar_t *ws2, locale_t) {
+  return wcscoll(ws1, ws2);
+}
+
+static inline size_t wcsxfrm_l(wchar_t *dest, const wchar_t *src, size_t n,
+                               locale_t) {
+  return wcsxfrm(dest, src, n);
+}
+
+static inline long double strtold_l(const char *nptr, char **endptr, locale_t) {
+  return strtold(nptr, endptr);
+}
+
+static inline long long strtoll_l(const char *nptr, char **endptr, int base,
+                                  locale_t) {
+  return strtoll(nptr, endptr, base);
+}
+
+static inline unsigned long long strtoull_l(const char *nptr, char **endptr,
+                                            int base, locale_t) {
+  return strtoull(nptr, endptr, base);
+}
+
+static inline long long wcstoll_l(const wchar_t *nptr, wchar_t **endptr,
+                                  int base, locale_t) {
+  return wcstoll(nptr, endptr, base);
+}
+
+static inline unsigned long long wcstoull_l(const wchar_t *nptr,
+                                            wchar_t **endptr, int base,
+                                            locale_t) {
+  return wcstoull(nptr, endptr, base);
+}
+
+static inline long double wcstold_l(const wchar_t *nptr, wchar_t **endptr,
+                                    locale_t) {
+  return wcstold(nptr, endptr);
+}
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif // _LIBCPP_SUPPORT_XLOCALE_XLOCALE_H