Our a16 support was only enabled for sample/gather and buffer load/store, but not for image load/store operations (which take an i16 as the pixel index rather than a half).
Fix our isel lowering and add test cases to prove it out.
Paths
| Differential D53750
[AMDGPU] support image load/store a16 ClosedPublic Authored by sheredom on Oct 26 2018, 2:24 AM.
Details Summary Our a16 support was only enabled for sample/gather and buffer load/store, but not for image load/store operations (which take an i16 as the pixel index rather than a half). Fix our isel lowering and add test cases to prove it out.
Diff Detail
Event TimelineHerald added subscribers: llvm-commits, t-tye, tpr and 5 others. · View Herald TranscriptOct 26 2018, 2:24 AM Comment Actions The function names of the a16.d16 tests should probably use vNf16 instead of vNf32. Please change that before committing, and please add a test for 2darraymsaa, to cover the v4i16 case of coordinates. Apart from that LGTM. This revision is now accepted and ready to land.Oct 27 2018, 8:30 AM Comment Actions Added an additional lit test for the dim variants (including the 2darraymsaa requested by @nhaehnle), and change the naming of the a16.d16 tests to vNf16. Closed by commit rL345710: [AMDGPU] support image load/store a16 (authored by sheredom). · Explain WhyOct 31 2018, 3:37 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 171883 llvm/trunk/lib/Target/AMDGPU/SIISelLowering.cpp
llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.image.a16.dim.ll
llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.image.load.a16.d16.ll
llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.image.load.a16.ll
llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.image.store.a16.d16.ll
llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.image.store.a16.ll
llvm/trunk/test/MC/AMDGPU/mimg.s
|