This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Fix immediate of rethrow when throwing to caller
ClosedPublic

Authored by aheejin on Oct 23 2018, 3:35 PM.

Details

Summary

Currently when assigning depths 'rethrow' does not take the whole
control flow stack into accounts but only considers EH pad stacks. When
assigning depth immmediates to rethrows, in normal cases it is done
correctly but when a rethrow instruction throws up to a caller, i.e., we
convert a pseudo RETHROW_TO_CALLER instruction to a rethrow, it
mistakenly compute the whole stack depth.

Diff Detail

Repository
rL LLVM

Event Timeline

aheejin created this revision.Oct 23 2018, 3:35 PM
dschuff accepted this revision.Oct 24 2018, 4:07 PM
This revision is now accepted and ready to land.Oct 24 2018, 4:07 PM
This revision was automatically updated to reflect the committed changes.