This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Allow undefined unwinder API reference when compiler does not specify unwinder lib
Needs ReviewPublic

Authored by ychen on Oct 22 2018, 8:33 PM.

Details

Summary

When building code referencing unwind lib, the compiler may not specify a unwind lib (in this case clang + compiler-rt).
Also HandleLLVMOptions.cmake uses -z,defs to prevent undef. In this case, the compilation would fail. (https://bugs.llvm.org/show_bug.cgi?id=28681)

There is also a similar patch for compiler-rt (for in-LLVM-tree build, standalone build does not enforce -z,defs ), which will be submitted in a separate patch in compiler-rt tree.

Diff Detail

Event Timeline

ychen created this revision.Oct 22 2018, 8:33 PM
ychen retitled this revision from [CMake] Allow undefined unwinder API reference when compiler does not specify unwinder lib (in this case clang + compiler-rt) There is also a similar patch for compiler-rt, which will be submitted in a separate patch in compiler-rt tree. to [CMake] Allow undefined unwinder API reference when compiler does not specify unwinder lib.Oct 23 2018, 8:04 AM
ychen edited the summary of this revision. (Show Details)
ychen edited the summary of this revision. (Show Details)Oct 23 2018, 8:15 AM
ychen added reviewers: lhames, mgorny.