Page MenuHomePhabricator

[clang-tidy] add IgnoreMacros option to eadability-redundant-smartptr-get
ClosedPublic

Authored by vmiklos on Oct 19 2018, 2:43 PM.

Details

Summary

And also enable it by default to be consistent with e.g. modernize-use-using.

This helps e.g. when running this check on client code where the macro is
provided by the system, so there is no easy way to modify it.

Diff Detail

Repository
rL LLVM

Event Timeline

vmiklos created this revision.Oct 19 2018, 2:43 PM

In practice cppunit's CPPUNIT_TEST_SUITE_END macro triggers this problem.

JonasToth accepted this revision.Oct 21 2018, 11:47 AM
JonasToth added a subscriber: JonasToth.

LGTM, but could you please add a short notice in the release notes?

This revision is now accepted and ready to land.Oct 21 2018, 11:47 AM

LGTM, but could you please add a short notice in the release notes?

Sure, I will do that.

This revision was automatically updated to reflect the committed changes.