Page MenuHomePhabricator

Add support for GNU Hurd in Path.inc and other places
ClosedPublic

Authored by sylvestre.ledru on Oct 18 2018, 1:18 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

sylvestre.ledru retitled this revision from Add support for GNU Hurd in Path.inc Patch by Svante Signell to Add support for GNU Hurd in Path.inc.
sylvestre.ledru edited the summary of this revision. (Show Details)

add path_max def

sylvestre.ledru retitled this revision from Add support for GNU Hurd in Path.inc to Add support for GNU Hurd in Path.inc and other places.Oct 18 2018, 1:24 PM
sylvestre.ledru edited the summary of this revision. (Show Details)

Can you provide some more information about why this is needed?

efriedma added inline comments.
tools/dsymutil/DwarfLinker.cpp
107 ↗(On Diff #170115)

This seems unnecessary; as far as I can tell, this file doesn't refer to PATH_MAX at all.

Debian still proposes a GNU Hurd port of this distro. As LLVM is now key, the porters have been trying to get llvm ported.
This fixes a bunch of issues and make llvm work correctly on gnu hurd.

https://buildd.debian.org/status/logs.php?pkg=llvm-toolchain-6.0&arch=hurd-i386

Remove the DwarfLinker.cpp declaration (useless)

efriedma accepted this revision.Oct 22 2018, 1:24 PM

LGTM

lib/Support/Unix/Path.inc
52 ↗(On Diff #170317)

We really shouldn't be using PATH_MAX/MAXPATHLEN at all, but this isn't any worse than what we're already doing.

This revision is now accepted and ready to land.Oct 22 2018, 1:24 PM
This revision was automatically updated to reflect the committed changes.