This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS.
ClosedPublic

Authored by danalbert on Oct 16 2018, 12:09 PM.

Details

Summary

C++ flags should not be used for not-C++ files as it may trigger
-Werror=unused-command-line-argument. CMake will use CMAKE_C_FLAGS,
CMAKE_CXX_FLAGS, and CMAKE_ASM_FLAGS as appropriate implicitly, so
this does not need to be explicitly handled here.

This change depends on https://reviews.llvm.org/D53301, since one of
the builders depended on this behavior because it was not configuring
CMAKE_ASM_FLAGS.

Diff Detail

Repository
rL LLVM

Event Timeline

danalbert created this revision.Oct 16 2018, 12:09 PM
Herald added subscribers: Restricted Project, delcypher, mgorny, dberris. · View Herald TranscriptOct 16 2018, 12:09 PM
vitalybuka accepted this revision.Oct 16 2018, 3:47 PM
This revision is now accepted and ready to land.Oct 16 2018, 3:47 PM
eugenis accepted this revision.Oct 16 2018, 4:38 PM

LGTM

This revision was automatically updated to reflect the committed changes.