This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Add createIndex in dexp
ClosedPublic

Authored by hokein on Oct 15 2018, 8:04 AM.

Details

Summary

This would allow easily injecting our internal customization.

Also updates the stale "symbol-collection-file" flag.

Event Timeline

hokein created this revision.Oct 15 2018, 8:04 AM
sammccall accepted this revision.Oct 15 2018, 8:07 AM
sammccall added inline comments.
clangd/index/dex/dexp/Dexp.cpp
256

createIndex seems a slightly odd name for this (as if writing new files or adding new data somehow): openIndex or so?

273

"to open the index"?

This revision is now accepted and ready to land.Oct 15 2018, 8:07 AM
hokein updated this revision to Diff 169712.Oct 15 2018, 8:13 AM
hokein marked 2 inline comments as done.

createIndex => openIndex

This revision was automatically updated to reflect the committed changes.