This is an archive of the discontinued LLVM Phabricator instance.

Differential D53225

[libfuzzer][Windows] Silence linker warning in unittest
ClosedPublic

Authored by metzman on Oct 12 2018, 3:47 PM.

Details

Reviewers
morehouse
Commits
rG9d0f3206ce52: [libfuzzer][Windows] Silence linker warning in unittest
rCRT344480: [libfuzzer][Windows] Silence linker warning in unittest
rL344480: [libfuzzer][Windows] Silence linker warning in unittest
Summary

Silence warning when linking unittest binary by not passing
-lstdc++ to the linker since it is ignored.

Diff Detail

Event Timeline

metzman created this revision.Oct 12 2018, 3:47 PM
Herald added a subscriber: mgorny. · View Herald TranscriptOct 12 2018, 3:47 PM
Harbormaster completed remote builds in B23759: Diff 169508.Oct 12 2018, 3:49 PM
metzman edited the summary of this revision. (Show Details)Oct 12 2018, 3:50 PM
metzman added a reviewer: morehouse.Oct 12 2018, 3:54 PM

Matt, could you please take a look at this trivial change.

It is intended to stop the warning: LINK : warning LNK4044: unrecognized option '/Z-reserved-lib-stdc++'; ignored when building the libFuzzer unittests on Windows.

metzman retitled this revision from [fuzzer][Windows] Silence linker warning in unittest to [libfuzzer][Windows] Silence linker warning in unittest.Oct 12 2018, 3:55 PM
morehouse accepted this revision.Oct 12 2018, 4:24 PM
This revision is now accepted and ready to land.Oct 12 2018, 4:24 PM
Closed by commit rL344480: [libfuzzer][Windows] Silence linker warning in unittest (authored by metzman). · Explain WhyOct 14 2018, 10:09 AM
This revision was automatically updated to reflect the committed changes.
Herald added subscribers: llvm-commits, delcypher. · View Herald TranscriptOct 14 2018, 10:09 AM

Revision Contents

PathSize
compiler-rt/
lib/
fuzzer/
tests/
4 lines

Diff 169508

compiler-rt/lib/fuzzer/tests/CMakeLists.txt

Show All 11 Lines
add_custom_target(FuzzerUnitTests) add_custom_target(FuzzerUnitTests)
set_target_properties(FuzzerUnitTests PROPERTIES FOLDER "Compiler-RT Tests") set_target_properties(FuzzerUnitTests PROPERTIES FOLDER "Compiler-RT Tests")
set(LIBFUZZER_UNITTEST_LINK_FLAGS ${COMPILER_RT_UNITTEST_LINK_FLAGS}) set(LIBFUZZER_UNITTEST_LINK_FLAGS ${COMPILER_RT_UNITTEST_LINK_FLAGS})
list(APPEND LIBFUZZER_UNITTEST_LINK_FLAGS --driver-mode=g++) list(APPEND LIBFUZZER_UNITTEST_LINK_FLAGS --driver-mode=g++)
if(APPLE OR CMAKE_SYSTEM_NAME STREQUAL "FreeBSD") if(APPLE OR CMAKE_SYSTEM_NAME STREQUAL "FreeBSD")
list(APPEND LIBFUZZER_UNITTEST_LINK_FLAGS -lc++ -lpthread) list(APPEND LIBFUZZER_UNITTEST_LINK_FLAGS -lc++ -lpthread)
elseif(WIN32) elseif(NOT WIN32)
list(APPEND LIBFUZZER_UNITTEST_LINK_FLAGS -lstdc++)
else()
list(APPEND LIBFUZZER_UNITTEST_LINK_FLAGS -lstdc++ -lpthread) list(APPEND LIBFUZZER_UNITTEST_LINK_FLAGS -lstdc++ -lpthread)
endif() endif()
if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux" AND COMPILER_RT_LIBCXX_PATH) if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux" AND COMPILER_RT_LIBCXX_PATH)
list(APPEND LIBFUZZER_UNITTEST_CFLAGS -nostdinc++ -D_LIBCPP_ABI_VERSION=Fuzzer) list(APPEND LIBFUZZER_UNITTEST_CFLAGS -nostdinc++ -D_LIBCPP_ABI_VERSION=Fuzzer)
endif() endif()
if(COMPILER_RT_DEFAULT_TARGET_ARCH IN_LIST FUZZER_SUPPORTED_ARCH) if(COMPILER_RT_DEFAULT_TARGET_ARCH IN_LIST FUZZER_SUPPORTED_ARCH)
Show All 34 Lines