This is an archive of the discontinued LLVM Phabricator instance.

Revert 344389 "Revert r344375 "[Driver] check for exit code from SIGPIPE""
ClosedPublic

Authored by nickdesaulniers on Oct 12 2018, 12:38 PM.

Diff Detail

Event Timeline

rnk accepted this revision.Oct 12 2018, 3:30 PM

I think it's fine, just remove the git hash from the commit message and just refer to the svn number.

This revision is now accepted and ready to land.Oct 12 2018, 3:30 PM
nickdesaulniers edited the summary of this revision. (Show Details)Oct 12 2018, 3:43 PM
This revision was automatically updated to reflect the committed changes.

I think this is now breaking:
lld :: ELF/format-binary.test
lld :: ELF/relocatable-versioned.s

Nevermind, looks like flaky tests. Will try to repro and contact msan maintainers.

Hi @nickdesaulniers
I have run into this too recently so would love to see this patch land. Did you get anywhere with those lld test failures?
Ta
Rich

Hi @richard.barton.arm , this has landed already. If you click "show older" you'll see the UI element that shows this landed as r344536 (Oct 15 2018). If your clang version is later than r344536 (what will become clang-8) and you still see this, please open a new bug. The commit is definitely confusing; it looks like a revert, but it's a revert of a revert (double negative) which is relanding the patch. The lld failures were PEBKAC on my part, unrelated to this patch.

Hi @nickdesaulniers - thanks for the clarification. I was suffering from some PEBCAK of my own when I thought the commits were not on master. Thanks for these patches - a great help.