Page MenuHomePhabricator

[AARCH64][FIX] Emit data symbol for constant pool data
ClosedPublic

Authored by dnsampaio on Oct 11 2018, 4:26 AM.

Details

Summary

The ARM64 elf emitter would omit printing data
symbol for zero filled constant data. This patch
overrides the emitFill method as to enforce that
the symbol is correctly printed.

Diff Detail

Repository
rL LLVM

Event Timeline

dnsampaio created this revision.Oct 11 2018, 4:26 AM
olista01 accepted this revision.Oct 11 2018, 6:13 AM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 11 2018, 6:13 AM
olista01 requested changes to this revision.Oct 11 2018, 6:14 AM

Actually, the test uses cortex-a76, but I don't think that's been committed yet. This isn't CPU-dependent, so you should be able to just remove the option.

This revision now requires changes to proceed.Oct 11 2018, 6:14 AM
dnsampaio updated this revision to Diff 169202.Oct 11 2018, 6:27 AM

Removed processor and specific triple target from test.

This revision is now accepted and ready to land.Oct 11 2018, 6:58 AM
This revision was automatically updated to reflect the committed changes.