This is an archive of the discontinued LLVM Phabricator instance.

Differential D52943

[llvm-nm] Write "no symbol" output to stderr
ClosedPublic

Authored by phosek on Oct 5 2018, 1:09 PM.

Details

Reviewers
rupprecht
MaskRay
• espindola
Commits
rG62f6462bf931: [llvm-nm] Write "no symbol" output to stderr
rC343887: [llvm-nm] Write "no symbol" output to stderr
rL343887: [llvm-nm] Write "no symbol" output to stderr
rLLD343887: [llvm-nm] Write "no symbol" output to stderr
Summary

This matches the output of binutils' nm and ensures that any scripts
or tools that use nm and expect empty output in case there no symbols
don't break.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

phosek created this revision.Oct 5 2018, 1:09 PM
Herald added subscribers: llvm-commits, dexonsmith, steven_wu and 2 others. · View Herald TranscriptOct 5 2018, 1:09 PM
rupprecht accepted this revision.Oct 5 2018, 1:36 PM

Thanks Petr, I completely missed that it was going to stderr!
There are two tests in lld and clang to update as well, see rL343743 and rL343744.

This revision is now accepted and ready to land.Oct 5 2018, 1:36 PM
phosek updated this revision to Diff 168530.Oct 5 2018, 1:56 PM

Thanks for pointing those out, I've included them in this change as well.

Herald added a reviewer: • espindola. · View Herald TranscriptOct 5 2018, 1:56 PM
Herald added subscribers: arichardson, emaste. · View Herald Transcript
Closed by commit rLLD343887: [llvm-nm] Write "no symbol" output to stderr (authored by phosek). · Explain WhyOct 5 2018, 2:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
ELF/
lto/
2 lines

Diff 168531

test/ELF/lto/thinlto-obj-path.ll

; REQUIRES: x86 ; REQUIRES: x86
; RUN: opt -module-summary %s -o %t1.o ; RUN: opt -module-summary %s -o %t1.o
; RUN: opt -module-summary %p/Inputs/thinlto.ll -o %t2.o ; RUN: opt -module-summary %p/Inputs/thinlto.ll -o %t2.o
; Test to ensure that thinlto-index-only with obj-path creates the file. ; Test to ensure that thinlto-index-only with obj-path creates the file.
; RUN: rm -f %t4.o ; RUN: rm -f %t4.o
; RUN: ld.lld --plugin-opt=thinlto-index-only --plugin-opt=obj-path=%t4.o -shared %t1.o %t2.o -o %t3 ; RUN: ld.lld --plugin-opt=thinlto-index-only --plugin-opt=obj-path=%t4.o -shared %t1.o %t2.o -o %t3
; RUN: llvm-readobj -h %t4.o | FileCheck %s ; RUN: llvm-readobj -h %t4.o | FileCheck %s
; RUN: llvm-nm %t4.o | FileCheck %s -check-prefix=NO-SYMBOLS ; RUN: llvm-nm %t4.o 2>&1 | FileCheck %s -check-prefix=NO-SYMBOLS
; NO-SYMBOLS: no symbols ; NO-SYMBOLS: no symbols
; CHECK: Format: ELF64-x86-64 ; CHECK: Format: ELF64-x86-64
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu" target triple = "x86_64-unknown-linux-gnu"
declare void @g(...) declare void @g(...)
define void @f() { define void @f() {
entry: entry:
call void (...) @g() call void (...) @g()
ret void ret void
} }