Page MenuHomePhabricator

Add R_HEX_GOT_16_X support
ClosedPublic

Authored by sidneym on Oct 4 2018, 3:24 PM.

Details

Summary

Wow! Just 280 lines of target-specific code and lld will link both the linux kernel and musl libc.so for hexagon.

Diff Detail

Repository
rL LLVM

Event Timeline

sidneym created this revision.Oct 4 2018, 3:24 PM
ruiu accepted this revision.Oct 4 2018, 3:38 PM

LGTM

Congratulations! I'm happy to see this concrete example that lld is *very* hackable and extremely easy to extend. :) We've been emphasizing simplicity, and it surely pays off.

This revision is now accepted and ready to land.Oct 4 2018, 3:38 PM
This revision was automatically updated to reflect the committed changes.
ruiu added a comment.Oct 8 2018, 11:10 AM

Sid,

Is this your final patch to support Hexagon, or do you have any other plans? I'm just wondering.

No this isn't, I'd like to add TLS support. I'm also sure some additional relocations will be required (beyond the TLS ones).