[analyzer] allow plugins built as shared libraries to receive events

[jranieri-grammatech]

Summary

Event types are uniqued by using the addresses of a local static defined in a header files, but it isn't the same across shared library boundaries and plugins can't currently handle ImplicitNullDerefEvents.

[Szelethus]

Please reupload with full context (-U9999).

lib/StaticAnalyzer/Core/Checker.cpp

20

nit: Static fields initialize to 0 without out of line definition.

[Szelethus]

lib/StaticAnalyzer/Core/Checker.cpp

20

Never mind, you still have to define it. It's been a while since I used static :).

[NoQ]

Yup, this one looks great as well. I'll commit. Thanks!

[NoQ]

I committed both patches as rC344823 but it seems that Phabricator doesn't pick up closing multiple revisions with the same commit, so closing manually.

Also thanks!~

include/clang/StaticAnalyzer/Core/Checker.h

   // dereference might happen later (for example pointer passed to a parameter
   // that is marked with nonnull attribute.)
   bool IsDirectDereference;
+
+  static int Tag;
 };
 
 /// A helper class which wraps a boolean value set to false by default.

include/clang/StaticAnalyzer/Core/CheckerManager.h

 
   template <typename EVENT>
   void _registerListenerForEvent(CheckEventFunc checkfn) {
-    EventInfo &info = Events[getTag<EVENT>()];
+    EventInfo &info = Events[&EVENT::Tag];
     info.Checkers.push_back(checkfn);
   }
 
   template <typename EVENT>
   void _registerDispatcherForEvent() {
-    EventInfo &info = Events[getTag<EVENT>()];
+    EventInfo &info = Events[&EVENT::Tag];
     info.HasDispatcher = true;
   }
 
   template <typename EVENT>
   void _dispatchEvent(const EVENT &event) const {
-    EventsTy::const_iterator I = Events.find(getTag<EVENT>());
+    EventsTy::const_iterator I = Events.find(&EVENT::Tag);
     if (I == Events.end())
       return;
     const EventInfo &info = I->second;

lib/StaticAnalyzer/Core/Checker.cpp

 using namespace clang;
 using namespace ento;
 
+int ImplicitNullDerefEvent::Tag;
+
 StringRef CheckerBase::getTagDescription() const {
   return getCheckName().getName();
 }