handleDeclOccurrencce reports a canonical declartion, so stick to use
canonical declarations to determine whether a declaration is in the
target set.
Also fix a previous ref test which misses a matched label (it fails without this
patch).
Paths
| Differential D52871
[clangd] Use canonical declarations in ReferenceFinder. ClosedPublic Authored by hokein on Oct 4 2018, 2:40 AM.
Details Summary handleDeclOccurrencce reports a canonical declartion, so stick to use Also fix a previous ref test which misses a matched label (it fails without this
Diff Detail
Event TimelineHerald added subscribers: kadircet, arphaman, jkorous and 3 others. · View Herald TranscriptOct 4 2018, 2:40 AM Comment Actions Nice catch!
This revision is now accepted and ready to land.Oct 4 2018, 2:48 AM Closed by commit rL343763: [clangd] Use canonical declarations in ReferenceFinder. (authored by hokein). · Explain WhyOct 4 2018, 2:59 AM Closed by commit rCTE343763: [clangd] Use canonical declarations in ReferenceFinder. (authored by hokein). · Explain Why This revision was automatically updated to reflect the committed changes. This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 168250 clangd/XRefs.cpp
unittests/clangd/XRefsTests.cpp
|
hmm, it looks like the "foo" labels on the ranges don't need to be there, and they hurt readability.
Want to remove them from all the tests, rather than add them to the method call test where they're missing?