This is an archive of the discontinued LLVM Phabricator instance.

Update CMakeLists.txt snippet so that example compiles
ClosedPublic

Authored by danzimm on Sep 28 2018, 11:25 AM.

Details

Summary

Previous to this the example didn't work out of the box, it seems some cmake config changed between when this was written and now.

Diff Detail

Repository
rC Clang

Event Timeline

danzimm created this revision.Sep 28 2018, 11:25 AM
steveire accepted this revision.Sep 28 2018, 11:41 AM
steveire added a subscriber: steveire.

Yes, add_llvm_executable uses target_link_libraries with PRIVATE for LLVM_PTHREAD_LIB. It is designed so that if you use the PUBLIC|PRIVATE|INTERFACE keyword with a target once, you have to do it at each location.

This revision is now accepted and ready to land.Sep 28 2018, 11:41 AM

Yep, that's my doing (rL319840). I didn't think about the documentation, whoops.

@steveire can you land this for me? I don't have commit access

This revision was automatically updated to reflect the committed changes.

Done! Thanks for the contribution!