This is an archive of the discontinued LLVM Phabricator instance.

Yes, add_llvm_executable uses target_link_libraries with PRIVATE for LLVM_PTHREAD_LIB. It is designed so that if you use the PUBLIC|PRIVATE|INTERFACE keyword with a target once, you have to do it at each location.

This revision is now accepted and ready to land.Sep 28 2018, 11:41 AM

Yep, that's my doing (rL319840). I didn't think about the documentation, whoops.

@steveire can you land this for me? I don't have commit access

Closed by commit rC343530: Update CMakeLists.txt snippet so that example compiles (authored by steveire). · Explain WhyOct 1 2018, 1:29 PM

This revision was automatically updated to reflect the committed changes.

Done! Thanks for the contribution!

Revision Contents

Path

Size

docs/

LibASTMatchersTutorial.rst

1 line

Diff 167521

docs/LibASTMatchersTutorial.rst

	Show First 20 Lines • Show All 107 Lines • ▼ Show 20 Lines
	::			::

	set(LLVM_LINK_COMPONENTS support)			set(LLVM_LINK_COMPONENTS support)

	add_clang_executable(loop-convert			add_clang_executable(loop-convert
	LoopConvert.cpp			LoopConvert.cpp
	)			)
	target_link_libraries(loop-convert			target_link_libraries(loop-convert
				PRIVATE
	clangTooling			clangTooling
	clangBasic			clangBasic
	clangASTMatchers			clangASTMatchers
	)			)

	With that done, Ninja will be able to compile our tool. Let's give it			With that done, Ninja will be able to compile our tool. Let's give it
	something to compile! Put the following into			something to compile! Put the following into
	``tools/extra/loop-convert/LoopConvert.cpp``. A detailed explanation of			``tools/extra/loop-convert/LoopConvert.cpp``. A detailed explanation of
	▲ Show 20 Lines • Show All 436 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

Update CMakeLists.txt snippet so that example compilesClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 167521

docs/LibASTMatchersTutorial.rst

Update CMakeLists.txt snippet so that example compiles
ClosedPublic