[OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h

[sidorovd]

Summary

PIPE_RESERVE_ID_VALID_BIT is implementation defined, so lets not keep it in the header.

Previously the topic was discussed here: https://reviews.llvm.org/D32896

[Anastasia]

Does it mean we should close https://reviews.llvm.org/D32896?

Would it make sense to keep this value as Clang implementation and if vendors need to change this they can undef it and redefine a new value. Would this work?

[sidorovd]

In D52658#1252744, @Anastasia wrote:

Does it mean we should close https://reviews.llvm.org/D32896?

Yes

In D52658#1252744, @Anastasia wrote:

Would it make sense to keep this value as Clang implementation and if vendors need to change this they can undef it and redefine a new value. Would this work?

This would work, but the macro isn't existing in the spec and while there already is implementation defined function 'is_valid_reserve_id()' I don't see any reason for PIPE_RESERVE_ID_VALID_BIT to be defined in the header.

[yaxunl]

I am OK with the change.

[Anastasia]

LGTM!

cfe/trunk/lib/Headers/opencl-c.h

 double __ovld __conv work_group_scan_inclusive_min(double x);
 double __ovld __conv work_group_scan_inclusive_max(double x);
 #endif //cl_khr_fp64
 
 #endif //__OPENCL_C_VERSION__ >= CL_VERSION_2_0
 
 // OpenCL v2.0 s6.13.16 - Pipe Functions
 #if __OPENCL_C_VERSION__ >= CL_VERSION_2_0
-#define PIPE_RESERVE_ID_VALID_BIT (1U << 30)
 #define CLK_NULL_RESERVE_ID (__builtin_astype(((void*)(__SIZE_MAX__)), reserve_id_t))
 bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);
 #endif //__OPENCL_C_VERSION__ >= CL_VERSION_2_0
 
 
 // OpenCL v2.0 s6.13.17 - Enqueue Kernels
 #if __OPENCL_C_VERSION__ >= CL_VERSION_2_0