This is an archive of the discontinued LLVM Phabricator instance.

[XRay] Add LD_LIBRARY_PATH to env variables for Unit Tests
ClosedPublic

Authored by dberris on Sep 27 2018, 3:25 AM.

Details

Summary

This change allows us to use the library path from which the LLVM
libraries are installed, in case the LLVM installation generates shared
libraries.

This should address llvm.org/PR39070.

Event Timeline

dberris created this revision.Sep 27 2018, 3:25 AM
MaskRay added inline comments.
compiler-rt/lib/xray/tests/CMakeLists.txt
74

Does xray unittests call clock_* timer_* mq_* that are provided by librt?
http://refspecs.linuxbase.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generic/librt.html

dberris added inline comments.Sep 27 2018, 10:36 AM
compiler-rt/lib/xray/tests/CMakeLists.txt
74

Yes -- is that going to be a problem?

MaskRay accepted this revision.Sep 27 2018, 11:09 AM
MaskRay added inline comments.
compiler-rt/lib/xray/tests/CMakeLists.txt
74

I have checked librt. sanitizer_posix_libcdep.cc used by xray calls shm_open and shm_unlink which require librt.so. The dependency is necessary.

This revision is now accepted and ready to land.Sep 27 2018, 11:09 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: Restricted Project. · View Herald TranscriptSep 27 2018, 4:17 PM