Page MenuHomePhabricator

mboerger (Marcus Boerger)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2018, 9:37 PM (41 w, 2 h)

Recent Activity

Dec 6 2018

mboerger accepted D55249: [XRay] Use preallocated memory for XRay profiling.

LGTM

Dec 6 2018, 10:23 PM

Dec 4 2018

mboerger added inline comments to D55249: [XRay] Use preallocated memory for XRay profiling.
Dec 4 2018, 10:45 PM

Nov 29 2018

mboerger accepted D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.

LGTM

Nov 29 2018, 8:26 PM

Nov 27 2018

mboerger added inline comments to D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
Nov 27 2018, 11:03 PM

Nov 19 2018

mboerger accepted D54684: [XRay] Move buffer extents back to the heap.

LGTM

Nov 19 2018, 3:48 PM
mboerger accepted D54684: [XRay] Move buffer extents back to the heap.

LGTM

Nov 19 2018, 2:06 PM
mboerger added inline comments to D54684: [XRay] Move buffer extents back to the heap.
Nov 19 2018, 8:05 AM

Nov 8 2018

mboerger accepted D54292: [XRay] Fix enter function tracing for record unwriting.
Nov 8 2018, 10:03 PM
mboerger accepted D54291: [XRay] Add atomic fences around non-atomic reads and writes.
Nov 8 2018, 10:02 PM
mboerger accepted D54201: [XRay] Improve FDR trace handling and error messaging.
Nov 8 2018, 10:01 PM

Nov 7 2018

mboerger added inline comments to D54201: [XRay] Improve FDR trace handling and error messaging.
Nov 7 2018, 9:59 PM

Nov 6 2018

mboerger accepted D54140: [XRay] Use TSC delta encoding for custom/typed events.

LGTM

Nov 6 2018, 6:47 PM

Nov 5 2018

mboerger added inline comments to D54140: [XRay] Use TSC delta encoding for custom/typed events.
Nov 5 2018, 11:56 PM
mboerger accepted D54139: [XRay] Update XRayRecord to support Custom/Typed Events.

LGTM

Nov 5 2018, 11:43 PM
mboerger added inline comments to D54139: [XRay] Update XRayRecord to support Custom/Typed Events.
Nov 5 2018, 11:00 PM

Nov 4 2018

mboerger accepted D54088: [XRay] Update TSC math to handle wraparound.

LGTM

Nov 4 2018, 9:37 PM

Nov 2 2018

mboerger accepted D54022: [XRay] Update delta computations in runtime.

LGTM

Nov 2 2018, 12:29 AM

Nov 1 2018

mboerger accepted D53967: [XRay] Fix TSC and atomic custom/typed event accounting.

LGTM

Nov 1 2018, 4:46 AM

Oct 31 2018

mboerger added inline comments to D53967: [XRay] Fix TSC and atomic custom/typed event accounting.
Oct 31 2018, 8:46 PM

Oct 30 2018

mboerger accepted D53920: [XRay] Add CPU ID in Custom Event FDR Records.

LGTM

Oct 30 2018, 11:41 PM

Oct 29 2018

mboerger accepted D53858: [XRay] Migrate FDR runtime to use refactored controller.

LGTM

Oct 29 2018, 9:29 PM

Oct 28 2018

mboerger accepted D53805: [XRay] Guard call to postCurrentThreadFCT().

LGTM

Oct 28 2018, 10:02 PM
mboerger accepted D53802: [XRay] Use more portable control block.

LGTM

Oct 28 2018, 7:15 PM

Oct 26 2018

mboerger accepted D53560: [XRay] Refcount backing store for buffers.

LGTM

Oct 26 2018, 7:47 PM
mboerger accepted D53551: [XRay] Support generational buffers in FDR controller.

LGTM

Oct 26 2018, 7:42 PM

Oct 22 2018

mboerger added inline comments to D53551: [XRay] Support generational buffers in FDR controller.
Oct 22 2018, 8:44 PM

Oct 21 2018

mboerger accepted D53484: [XRay] Handle allocator exhaustion in segmented array.

LGTM

Oct 21 2018, 7:09 PM

Oct 14 2018

mboerger accepted D52974: [XRay][compiler-rt] Generational Buffer Management.

LGTM

Oct 14 2018, 11:04 PM

Oct 10 2018

mboerger accepted D52588: [XRay][compiler-rt] FDR Mode Controller.

LGTM

Oct 10 2018, 11:49 PM

Oct 8 2018

mboerger added inline comments to D52588: [XRay][compiler-rt] FDR Mode Controller.
Oct 8 2018, 4:52 AM
mboerger added inline comments to D52974: [XRay][compiler-rt] Generational Buffer Management.
Oct 8 2018, 4:33 AM

Sep 21 2018

mboerger accepted D52349: [XRay] Clean up XRay build configuration.

LGTM

Sep 21 2018, 4:06 AM
mboerger accepted D52342: [XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1.

LGTM

Sep 21 2018, 1:14 AM
mboerger accepted D52342: [XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1.

LGTM

Sep 21 2018, 1:04 AM

Sep 18 2018

mboerger accepted D52220: [XRay][compiler-rt] FDRLogWriter Abstraction.

LGTM

Sep 18 2018, 6:10 AM
mboerger added inline comments to D52220: [XRay][compiler-rt] FDRLogWriter Abstraction.
Sep 18 2018, 5:20 AM
mboerger accepted D52220: [XRay][compiler-rt] FDRLogWriter Abstraction.

LGTM

Sep 18 2018, 12:52 AM

Sep 14 2018

mboerger accepted D52077: [XRay] Simplify FDR buffer management.

LGTM

Sep 14 2018, 8:00 AM

Sep 13 2018

mboerger accepted D51965: [XRay] Bug fixes for FDR custom event and arg-logging.

LGTM

Sep 13 2018, 1:56 AM
mboerger accepted D52015: [XRay][clang] Emit "never-instrument" attribute.

LGTM

Sep 13 2018, 1:51 AM

Sep 12 2018

mboerger added inline comments to D51965: [XRay] Bug fixes for FDR custom event and arg-logging.
Sep 12 2018, 12:37 AM

Sep 10 2018

mboerger accepted D51911: [XRay] Add TSC to NewCPUId Records.

LGTM

Sep 10 2018, 11:36 PM
mboerger accepted D51912: [XRay] Use FDR Records+Visitors for Trace Loading.

LGTM

Sep 10 2018, 11:09 PM
mboerger added inline comments to D51911: [XRay] Add TSC to NewCPUId Records.
Sep 10 2018, 11:03 PM

Sep 9 2018

mboerger accepted D51846: [XRay] Add the `llvm-xray fdr-dump` implementation.

LGTM

Sep 9 2018, 11:25 PM

Sep 7 2018

mboerger added a comment to D51776: [XRay] XRAY_NEVER_INSTRUMENT more functions, consolidate allocators.

LGTM

Sep 7 2018, 2:41 AM

Sep 6 2018

mboerger added a comment to rL341631: Revert "[XRay] Add a BlockVerifier visitor for FDR Records".

LGTM

Sep 6 2018, 8:53 PM
mboerger added a comment to D51723: [XRay] Add a BlockVerifier visitor for FDR Records.

As discussed, I find the transition comments unnecessary because the code is self explaining. So I'd prefer to have them removed, but up to you.

Sep 6 2018, 4:50 PM

Sep 5 2018

mboerger accepted D51673: [XRay] Add a BlockIndexer visitor for FDR Records..

LGTM

Sep 5 2018, 9:54 PM