This is an archive of the discontinued LLVM Phabricator instance.

Differential D52571

[Sema] Handle __va_start for Windows/ARM64 in the same way as for ARM
ClosedPublic

Authored by mstorsjo on Sep 26 2018, 1:18 PM.

Details

Reviewers
dmajor
mgrang
ssijaric
rnk
compnerd
Commits
rG0b339e4d80ea: [Sema] Handle __va_start for Windows/ARM64 in the same way as for ARM
rC343184: [Sema] Handle __va_start for Windows/ARM64 in the same way as for ARM
rL343184: [Sema] Handle __va_start for Windows/ARM64 in the same way as for ARM
Summary

This fixes PR39090.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Sep 26 2018, 1:18 PM
Herald added subscribers: chrib, kristof.beyls. · View Herald TranscriptSep 26 2018, 1:18 PM
rnk accepted this revision.Sep 26 2018, 1:43 PM

lgtm

This revision is now accepted and ready to land.Sep 26 2018, 1:43 PM
Closed by commit rL343184: [Sema] Handle __va_start for Windows/ARM64 in the same way as for ARM (authored by mstorsjo). · Explain WhySep 27 2018, 1:29 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 27 2018, 1:29 AM

Revision Contents

PathSize
cfe/
trunk/
lib/
Sema/
1 line
test/
SemaCXX/
1 line

Diff 167244

cfe/trunk/lib/Sema/SemaChecking.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 923 Lines • ▼ Show 20 LinesSema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID,
case Builtin::BI__builtin_ms_va_start: case Builtin::BI__builtin_ms_va_start:
case Builtin::BI__builtin_stdarg_start: case Builtin::BI__builtin_stdarg_start:
case Builtin::BI__builtin_va_start: case Builtin::BI__builtin_va_start:
if (SemaBuiltinVAStart(BuiltinID, TheCall)) if (SemaBuiltinVAStart(BuiltinID, TheCall))
return ExprError(); return ExprError();
break; break;
case Builtin::BI__va_start: { case Builtin::BI__va_start: {
switch (Context.getTargetInfo().getTriple().getArch()) { switch (Context.getTargetInfo().getTriple().getArch()) {
case llvm::Triple::aarch64:
case llvm::Triple::arm: case llvm::Triple::arm:
case llvm::Triple::thumb: case llvm::Triple::thumb:
if (SemaBuiltinVAStartARMMicrosoft(TheCall)) if (SemaBuiltinVAStartARMMicrosoft(TheCall))
return ExprError(); return ExprError();
break; break;
default: default:
if (SemaBuiltinVAStart(BuiltinID, TheCall)) if (SemaBuiltinVAStart(BuiltinID, TheCall))
return ExprError(); return ExprError();
▲ Show 20 Lines • Show All 12,762 Lines • Show Last 20 Lines

cfe/trunk/test/SemaCXX/microsoft-varargs.cpp

// RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only %s -verify // RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only %s -verify
// RUN: %clang_cc1 -triple aarch64-windows -fms-compatibility -fsyntax-only %s -verify
// expected-no-diagnostics // expected-no-diagnostics
extern "C" { extern "C" {
typedef char * va_list; typedef char * va_list;
void __va_start(va_list *, ...); void __va_start(va_list *, ...);
} }
int test___va_start(int i, ...) { int test___va_start(int i, ...) {
Show All 18 Lines