This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] [builtins] Restore tests from r342917 (disabled in r343095) on Windows.
ClosedPublic

Authored by rupprecht on Sep 26 2018, 10:54 AM.

Details

Summary

-lm is needed for these tests on Linux, but the lit config for this package automatically adds it for Linux and excludes it for Windows. So we should be able to get these tests running again by just dropping -lm and let the lit config add it when possible.

I was under the impression that -lm worked across platforms because it exists in other tests without any 'UNSUPPORTED: windows' commands (e.g. see divsc3_test.c), but those are actually excluded because they 'REQUIRES: c99-complex' which is excluded from windows platforms (also by the local lit config).

I don't have easy access to a windows machine to verify this patch, but I can trigger a build bot run on clang-x64-ninja-win7 shortly after submitting.

Event Timeline

rupprecht created this revision.Sep 26 2018, 10:54 AM
rupprecht edited the summary of this revision. (Show Details)Sep 26 2018, 10:54 AM
hans accepted this revision.Sep 27 2018, 12:36 AM

I've verified the tests now pass on Windows. Thanks!

This revision is now accepted and ready to land.Sep 27 2018, 12:36 AM
This revision was automatically updated to reflect the committed changes.