Page MenuHomePhabricator

Allow later -z name=<int> args to override earlier args
ClosedPublic

Authored by rprichard on Sep 25 2018, 5:43 PM.

Details

Summary

lld already gives later -z options precedence in getZFlag().

This matches the behavior of ld.bfd and ld.gold, where later options
override earlier ones. (I tested with -z max-page-size and -z stack-size.)

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

rprichard created this revision.Sep 25 2018, 5:43 PM

I noticed this issue while experimenting with a new -z option, not when using -z max-page-size or -z stack-size.

grimar accepted this revision.Sep 26 2018, 2:31 AM
grimar added a subscriber: grimar.

LGTM

This revision is now accepted and ready to land.Sep 26 2018, 2:31 AM
ruiu accepted this revision.Sep 26 2018, 9:55 AM

LGTM

This revision was automatically updated to reflect the committed changes.