This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis][NFC] Rewrite of the YAML serialization.
ClosedPublic

Authored by gchatelet on Sep 24 2018, 9:44 AM.

Details

Summary

This is a NFC in preparation of exporting the initial registers as part of the YAML dump

Diff Detail

Event Timeline

gchatelet created this revision.Sep 24 2018, 9:44 AM
gchatelet updated this revision to Diff 166707.Sep 24 2018, 9:47 AM
  • Add missing Yin.setCurrentDocument()
  • Add missing Yin.setCurrentDocument()
  • Fix typo.
courbet added inline comments.Sep 25 2018, 1:55 AM
tools/llvm-exegesis/lib/BenchmarkResult.cpp
239

Let's add a second if (Context.error())

gchatelet updated this revision to Diff 166834.Sep 25 2018, 2:44 AM
  • Make YamlContext return an Error.
gchatelet marked an inline comment as done.Sep 25 2018, 2:47 AM
courbet accepted this revision.Sep 25 2018, 5:00 AM
This revision is now accepted and ready to land.Sep 25 2018, 5:00 AM
This revision was automatically updated to reflect the committed changes.