This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Add lit tests.
ClosedPublic

Authored by courbet on Sep 24 2018, 2:36 AM.

Details

Summary

Right now we only have unit tests. This will allow testing the whole
tool. Even though We can't really check actual values, this will avoid
regressions such as PR39055.

Diff Detail

Repository
rL LLVM

Event Timeline

courbet created this revision.Sep 24 2018, 2:36 AM
gchatelet accepted this revision.Sep 24 2018, 5:42 AM
This revision is now accepted and ready to land.Sep 24 2018, 5:42 AM
courbet updated this revision to Diff 166832.Sep 25 2018, 2:27 AM

Fix target support: x86 -> X86.

This revision was automatically updated to reflect the committed changes.
lebedev.ri added inline comments.
llvm/trunk/test/tools/llvm-exegesis/X86/lit.local.cfg
4

You also need to be running on a CPU for which there is a llvm-exegesis-friendly sched profile (i.e. counters are specified), and you are allowed to read those counters.

courbet added inline comments.Sep 25 2018, 2:36 AM
llvm/trunk/test/tools/llvm-exegesis/X86/lit.local.cfg
4

Ah, yes, thanks Roman. I'll revert this.

lebedev.ri added inline comments.Sep 25 2018, 2:38 AM
llvm/trunk/test/tools/llvm-exegesis/X86/lit.local.cfg
4

Can you instead do run-time detection here?
Try running that runline, and if it fails, mark as unsupported?