This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Fix the definition of the check-cxx-abilist target on Darwin
ClosedPublic

Authored by ldionne on Sep 22 2018, 11:13 AM.

Details

Summary

r342805 added support for the check-cxx-abilist target on FreeBSD, but broke
the target on macOS in doing so. The problem is that the GENERIC_TARGET_TRIPLE
gets overwritten after replacing the FreeBSD regular expression, which
nullifies the replacement done with the darwin regular expression.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Sep 22 2018, 11:13 AM
ldionne updated this revision to Diff 166613.Sep 22 2018, 11:16 AM

Remove the change to the Darwin ABI list file, which was meant for a different commit.

Harbormaster completed remote builds in B22960: Diff 166613.
EricWF accepted this revision.Sep 22 2018, 11:23 AM
This revision is now accepted and ready to land.Sep 22 2018, 11:23 AM
This revision was automatically updated to reflect the committed changes.
dim added a comment.Sep 22 2018, 12:38 PM

Ah, sorry about that! I should have realized this, but my CMake-fu is weak. :)