This is an archive of the discontinued LLVM Phabricator instance.

Differential D52393

[libunwind][NFC] Suppress unused parameter warnings
ClosedPublic

Authored by ldionne on Sep 22 2018, 11:03 AM.

Details

Reviewers
EricWF
Commits
rG2e667527c567: [libunwind][NFC] Suppress unused parameter warnings
rUNW342811: [libunwind][NFC] Suppress unused parameter warnings
rL342811: [libunwind][NFC] Suppress unused parameter warnings

Diff Detail

Event Timeline

ldionne created this revision.Sep 22 2018, 11:03 AM
Herald added subscribers: cfe-commits, dexonsmith, chrib, christof. · View Herald TranscriptSep 22 2018, 11:03 AM
Harbormaster completed remote builds in B22958: Diff 166609.Sep 22 2018, 11:03 AM
EricWF accepted this revision.Sep 22 2018, 11:14 AM
This revision is now accepted and ready to land.Sep 22 2018, 11:14 AM
Closed by commit rL342811: [libunwind][NFC] Suppress unused parameter warnings (authored by ldionne). · Explain WhySep 22 2018, 11:22 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 22 2018, 11:22 AM

Revision Contents

PathSize
libunwind/
src/
5 lines

Diff 166609

libunwind/src/Registers.hpp

Show First 20 Lines • Show All 511 Lines • ▼ Show 20 Lines
inline bool Registers_x86_64::validVectorRegister(int regNum) const { inline bool Registers_x86_64::validVectorRegister(int regNum) const {
#if defined(_WIN64) #if defined(_WIN64)
if (regNum < UNW_X86_64_XMM0) if (regNum < UNW_X86_64_XMM0)
return false; return false;
if (regNum > UNW_X86_64_XMM15) if (regNum > UNW_X86_64_XMM15)
return false; return false;
return true; return true;
#else #else
(void)regNum; // suppress unused parameter warning
return false; return false;
#endif #endif
} }
inline v128 Registers_x86_64::getVectorRegister(int regNum) const { inline v128 Registers_x86_64::getVectorRegister(int regNum) const {
#if defined(_WIN64) #if defined(_WIN64)
assert(validVectorRegister(regNum)); assert(validVectorRegister(regNum));
return _xmm[regNum - UNW_X86_64_XMM0]; return _xmm[regNum - UNW_X86_64_XMM0];
#else #else
(void)regNum; // suppress unused parameter warning
_LIBUNWIND_ABORT("no x86_64 vector registers"); _LIBUNWIND_ABORT("no x86_64 vector registers");
#endif #endif
} }
inline void Registers_x86_64::setVectorRegister(int regNum, v128 value) { inline void Registers_x86_64::setVectorRegister(int regNum, v128 value) {
#if defined(_WIN64) #if defined(_WIN64)
assert(validVectorRegister(regNum)); assert(validVectorRegister(regNum));
_xmm[regNum - UNW_X86_64_XMM0] = value; _xmm[regNum - UNW_X86_64_XMM0] = value;
#else #else
(void)regNum; (void)value; // suppress unused parameter warnings
_LIBUNWIND_ABORT("no x86_64 vector registers"); _LIBUNWIND_ABORT("no x86_64 vector registers");
#endif #endif
} }
#endif // _LIBUNWIND_TARGET_X86_64 #endif // _LIBUNWIND_TARGET_X86_64
#if defined(_LIBUNWIND_TARGET_PPC) #if defined(_LIBUNWIND_TARGET_PPC)
/// Registers_ppc holds the register state of a thread in a 32-bit PowerPC /// Registers_ppc holds the register state of a thread in a 32-bit PowerPC
▲ Show 20 Lines • Show All 1,598 Lines • ▼ Show 20 Linesinline Registers_arm::Registers_arm()
: _use_X_for_vfp_save(false), : _use_X_for_vfp_save(false),
_saved_vfp_d0_d15(false), _saved_vfp_d0_d15(false),
_saved_vfp_d16_d31(false) { _saved_vfp_d16_d31(false) {
memset(&_registers, 0, sizeof(_registers)); memset(&_registers, 0, sizeof(_registers));
memset(&_vfp_d0_d15_pad, 0, sizeof(_vfp_d0_d15_pad)); memset(&_vfp_d0_d15_pad, 0, sizeof(_vfp_d0_d15_pad));
memset(&_vfp_d16_d31, 0, sizeof(_vfp_d16_d31)); memset(&_vfp_d16_d31, 0, sizeof(_vfp_d16_d31));
#if defined(__ARM_WMMX) #if defined(__ARM_WMMX)
_saved_iwmmx = false; _saved_iwmmx = false;
_saved_iwmmx_control = false; _saved_iwmmx_control = false;
memset(&_iwmmx, 0, sizeof(_iwmmx)); memset(&_iwmmx, 0, sizeof(_iwmmx));
memset(&_iwmmx_control, 0, sizeof(_iwmmx_control)); memset(&_iwmmx_control, 0, sizeof(_iwmmx_control));
#endif #endif
} }
inline bool Registers_arm::validRegister(int regNum) const { inline bool Registers_arm::validRegister(int regNum) const {
// Returns true for all non-VFP registers supported by the EHABI // Returns true for all non-VFP registers supported by the EHABI
// virtual register set (VRS). // virtual register set (VRS).
▲ Show 20 Lines • Show All 1,148 Lines • Show Last 20 Lines